Repository navigation
Fix Android edge-panel drops and publish versioned releases automatically - #8
Conversation
- Route edge panel drops through a dedicated surface - Add regression coverage for drops handled by child views
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
- Select and stamp stable versions for Linux and Android releases - Publish signed AppImages after successful main CI runs - Update the Linux updater to install newer stable releases
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2830085819
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| concurrency: | ||
| group: release-${{ inputs.version || github.ref_name }} | ||
| group: airbridge-release | ||
| queue: max |
There was a problem hiding this comment.
Remove the unsupported concurrency queue key
GitHub Actions rejects this workflow because queue is not a supported property of the concurrency map; the documented keys are only group and cancel-in-progress. Consequently none of the automatic, tag, or manual release paths can run until this field is removed or serialization is implemented differently. See GitHub's concurrency syntax.
Useful? React with 👍 / 👎.
| if: >- | ||
| github.event_name != 'workflow_run' || | ||
| (github.event.workflow_run.conclusion == 'success' && | ||
| github.event.workflow_run.event == 'push' && | ||
| github.event.workflow_run.head_repository.full_name == github.repository) |
There was a problem hiding this comment.
Reject stale main workflow reruns before assigning a version
When an older failed or cancelled CI run is rerun after newer main releases exist, its completed workflow_run still passes this condition because only the original event and repository are checked. Line 45 then checks out that run's old head_sha, while the version selector assigns the next patch, publishing stale code as the newest semantic version and causing current installations to offer a downgrade. Verify that head_sha is still the tip of main before creating an automatic release.
Useful? React with 👍 / 👎.
Summary
Android: edge drop card receives drops
FrameLayout, and a Compose child could consumeACTION_DROPfirst.DropLayoutkeeps a transparent drag target above all children (both the handle and the open card), so drops always reach the listener and Android's native URI grant is preserved.DropLayoutTestreproduces the swallowed drop.Releases: v0.1.5, v0.1.6, … after every green main CI
release.ymlruns on successful CI for pushes tomainin this repo (not PRs or forks), picks the next patch version (.github/scripts/release_version.py, with tests), stamps Cargo and AndroidversionName/versionCode, signs the AppImage (signature bound to its tag), and publishes a normal release. Releases are serialized withconcurrency.queue: max.main-Nprerelease job inci.ymlis removed.vX.Y.Zreleases (semantic comparison, strictly newer only, drafts/prereleases ignored), still refusing unsigned or tampered AppImages.Testing
cargo fmt,cargo clippy --all-targets -- -D warnings,cargo test(46) — passed.Notes
main-Nupdater won't see versioned releases; download v0.1.5 manually once.🤖 Generated with Claude Code