Skip to content

Fix Android edge-panel drops and publish versioned releases automatically - #8

Merged
MDHaarith merged 2 commits into
mainfrom
feature/signed-appimage-updates
Oct 22, 2026
Merged

MDHaarith merged 2 commits into
mainfrom
feature/signed-appimage-updates

Conversation

@MDHaarith

@MDHaarith MDHaarith commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Android: edge drop card receives drops

  • Dropping a file on a device row in the screen-edge card did nothing: the drag listener sat on the parent FrameLayout, and a Compose child could consume ACTION_DROP first.
  • New DropLayout keeps a transparent drag target above all children (both the handle and the open card), so drops always reach the listener and Android's native URI grant is preserved.
  • Regression test DropLayoutTest reproduces the swallowed drop.

Releases: v0.1.5, v0.1.6, … after every green main CI

  • release.yml runs on successful CI for pushes to main in this repo (not PRs or forks), picks the next patch version (.github/scripts/release_version.py, with tests), stamps Cargo and Android versionName/versionCode, signs the AppImage (signature bound to its tag), and publishes a normal release. Releases are serialized with concurrency.queue: max.
  • The main-N prerelease job in ci.yml is removed.
  • The in-app updater now follows stable vX.Y.Z releases (semantic comparison, strictly newer only, drafts/prereleases ignored), still refusing unsigned or tampered AppImages.

Testing

  • cargo fmt, cargo clippy --all-targets -- -D warnings, cargo test (46) — passed.
  • Release-version tests (Python unittest) — passed.
  • Android unit + screenshot tests — 36 passed; release APK built and signature-verified.
  • Phone retest of the edge drop card — pending.

Notes

  • Merging triggers the first automatic public release, v0.1.5.
  • AppImages built from the main-N updater won't see versioned releases; download v0.1.5 manually once.

🤖 Generated with Claude Code

- Route edge panel drops through a dedicated surface
- Add regression coverage for drops handled by child views
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T20:32:55.565888Z 2830085 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

- Select and stamp stable versions for Linux and Android releases
- Publish signed AppImages after successful main CI runs
- Update the Linux updater to install newer stable releases
@MDHaarith MDHaarith changed the title Keep Android drop targets above decorative children Fix Android edge-panel drops and publish versioned releases automatically Oct 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2830085819

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

concurrency:
group: release-${{ inputs.version || github.ref_name }}
group: airbridge-release
queue: max

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the unsupported concurrency queue key

GitHub Actions rejects this workflow because queue is not a supported property of the concurrency map; the documented keys are only group and cancel-in-progress. Consequently none of the automatic, tag, or manual release paths can run until this field is removed or serialization is implemented differently. See GitHub's concurrency syntax.

Useful? React with 👍 / 👎.

Comment on lines +31 to +35
if: >-
github.event_name != 'workflow_run' ||
(github.event.workflow_run.conclusion == 'success' &&
github.event.workflow_run.event == 'push' &&
github.event.workflow_run.head_repository.full_name == github.repository)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reject stale main workflow reruns before assigning a version

When an older failed or cancelled CI run is rerun after newer main releases exist, its completed workflow_run still passes this condition because only the original event and repository are checked. Line 45 then checks out that run's old head_sha, while the version selector assigns the next patch, publishing stale code as the newest semantic version and causing current installations to offer a downgrade. Verify that head_sha is still the tip of main before creating an automatic release.

Useful? React with 👍 / 👎.

@MDHaarith
MDHaarith merged commit f63125d into main Oct 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant