-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin The Great Documention #779
base: main
Are you sure you want to change the base?
Changes from all commits
c081ddd
6e1e174
817f7db
a1d9f9a
ef53ae6
ccaaad3
7daefcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -216,7 +216,7 @@ | |||||||||
! log_directory | ||||||||||
! ~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! for data files about the run | ||||||||||
! directory for data files about the run | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -226,7 +226,7 @@ | |||||||||
! do_history_file | ||||||||||
! ~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! history file is created if this is true | ||||||||||
! a history file is created if this is true | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1115,7 +1115,7 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when the center entropy is above/below the upper/lower limit. | ||||||||||
! in kerg per baryon | ||||||||||
! in kerg per baryon, where kerg = (erg K^-1) | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1129,7 +1129,7 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when the max entropy is above/below the upper/lower limit. | ||||||||||
! in kerg per baryon | ||||||||||
! in kerg per baryon, where kerg = (erg K^-1) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above:
Suggested change
or
Suggested change
|
||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1183,7 +1183,7 @@ | |||||||||
! Lower limits on surface mass fractions. | ||||||||||
! Stop when surface abundance drops below this limit. | ||||||||||
! Can have up to ``num_xa_surface_limits`` of these (see ``star_def`` for value) | ||||||||||
! ``xa_surface_lower_limit_species`` contains an isotope name as defined in ``chem_def.f`` | ||||||||||
! ``xa_surface_lower_limit_species`` contains an isotope name as defined in ``chem_def.f90`` | ||||||||||
! ``xa_surface_lower_limit`` contains the lower limit value | ||||||||||
|
||||||||||
! :: | ||||||||||
|
@@ -1246,7 +1246,7 @@ | |||||||||
! HB_limit | ||||||||||
! ~~~~~~~~ | ||||||||||
|
||||||||||
! For detecting horizontal branch. | ||||||||||
! For detecting when the model has completed the horizontal branch. | ||||||||||
! Only applies when center abundance by mass of h1 is < 1d-4. | ||||||||||
! Stop when the center abundance by mass of he4 drops below this limit. | ||||||||||
|
||||||||||
|
@@ -1298,6 +1298,8 @@ | |||||||||
! star_species_mass_max_limit_iso | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! Stop when a particular species mass in units of Msun exceeds these limits. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
star_species_mass_min_limit = 0 | ||||||||||
|
@@ -1972,6 +1974,9 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when Lnuc/L is greater than this limit. | ||||||||||
! Here, Lnuc refers to the total thermal power from all burning, including photodisintegrations, | ||||||||||
! ``power_nuc_burn`` in the history_columns.list file. | ||||||||||
! L is the luminosity at the photosphere. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1982,6 +1987,9 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when Lnuc/L is less than this limit. | ||||||||||
! Here, Lnuc refers to the total thermal power from all burning, including photodisintegrations, | ||||||||||
! ``power_nuc_burn`` in the history_columns.list file. | ||||||||||
! L is the luminosity at the photosphere. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -2022,7 +2030,7 @@ | |||||||||
! Pgas_div_P_limit | ||||||||||
! ~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! criteria for stopping on Pgas/P | ||||||||||
! criteria for stopping when Pgas/P <= Pgas_div_P_limit | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For parity with other similar controls
Suggested change
|
||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -2032,7 +2040,7 @@ | |||||||||
! Pgas_div_P_limit_max_q | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop if Pgas/P < this limit at any location with ``q <= Pgas_div_P_limit_max_q`` | ||||||||||
! stop if Pgas/P < Pgas_div_P_limit at any location with ``q <= Pgas_div_P_limit_max_q`` | ||||||||||
! values near unity skip the outer envelope | ||||||||||
|
||||||||||
! :: | ||||||||||
|
@@ -4109,8 +4117,8 @@ | |||||||||
|
||||||||||
D_mix_rotation_min_tau_full_off = 0d0 | ||||||||||
|
||||||||||
! D_mix_rotation_max_tau_full_on | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
! D_mix_rotation_max_tau_full_on | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! Use rotational components of ``D_mix`` for locations where tau >= this. | ||||||||||
! For numerical stability, turn off rotational part of ``D_mix`` at very low tau. | ||||||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -689,6 +689,8 @@ | |||||
! set hydrogen and helium mass fractions according to the following: | ||||||
! If no h2 in current net, then this will be added to h1. | ||||||
! If no he3 in current net, then this will be added to he4. | ||||||
! When ``set_uniform_initial_composition = .false.``, defer to | ||||||
! composition controls in &controls.defaults. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Though we aren't being very consistent about monospace yet, I think this should be
Suggested change
|
||||||
|
||||||
! :: | ||||||
|
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just
or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you @warrickball ! It's just that kerg gets used all over in Mesa documentation and output headers, so I think we should correct these all at once. Should we do it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, if it's a reasonably common unit, perhaps we don't need to change it, but I'd never encountered it before.
If we are going to change it in a lot of places at once, I agree with doing it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment from the peanut gallery. i disagree with adding per baryon. electrons, leptons, have an entropy that is added to the total. photons, bosons, also have an entropy that is added in. an entropy of mixing is also added. none of these other contributions to the total entropy have baryons associated with them.