Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom colors overhaul #786

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

nialljmiller
Copy link
Collaborator

No description provided.

@@ -0,0 +1,28 @@
# Ignore the data directory
Copy link
Contributor

@warrickball warrickball Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be rationalised against the top-level .gitignore, and the fact that we shouldn't encounter some of these files (e.g. .dll).

The only other two test cases that have .gitignore files are ccsn_IIp and tzo, and those are mostly for a few very specific model files.

@Debraheem
Copy link
Member

A broad question, is this just for the test_suite or does it involved the $MESA_DIR/star/colors module? Will some of this be moved into the colors module?

@mjoyceGR
Copy link
Member

The idea is to eventually overhaul the colors module at the module level, but that will require pre-building some large files (there was discussion of this at the end of yesterday's dev call). For now, we're testing this functionality with only one filter system at the test_suite level

@mjoyceGR mjoyceGR self-assigned this Feb 20, 2025
@mjoyceGR mjoyceGR added the colors colors module label Feb 20, 2025
@nialljmiller nialljmiller force-pushed the features/nialljmiller/customcolors branch from 244b851 to 5c94961 Compare February 22, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
colors colors module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants