re-naming variables to make tests happy.

MISP · Jul 22, 2024 · 4e85c93 · 4e85c93
1 parent 2665aff
commit 4e85c93
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/pymisp/api.py b/pymisp/api.py
@@ -2706,9 +2706,9 @@ def add_role(self, role: MISPRole, pythonify: bool = False) -> dict[str, Any] |
         role_j = self._check_json_response(r)
         if not (self.global_pythonify or pythonify) or 'errors' in role_j:
             return role_j
-        r = MISPRole()
-        r.from_dict(**role_j)
-        return r
+        new_misp_role = MISPRole()
+        new_misp_role.from_dict(**role_j)
+        return new_misp_role
 
     def update_role(self, role: MISPRole, role_id: int | None = None, pythonify: bool = False) -> dict[str, Any] | MISPRole:
         """Update a role on a MISP instance
@@ -2726,9 +2726,9 @@ def update_role(self, role: MISPRole, role_id: int | None = None, pythonify: boo
         updated_role = self._check_json_response(r)
         if not (self.global_pythonify or pythonify) or 'errors' in updated_role:
             return updated_role
-        e = MISPRole()
-        e.from_dict(**updated_role)
-        return e
+        updated_misp_role = MISPRole()
+        updated_misp_role.from_dict(**updated_role)
+        return updated_misp_role
 
     def set_default_role(self, role: MISPRole | int | str | UUID) -> dict[str, Any] | list[dict[str, Any]]:
         """Set a default role for the new user accounts