Skip to content

fix(file): consistent function renderer in file functions tab #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rdmmf wants to merge 1 commit into
base: dev
Choose a base branch
from
+2 −14
Draft

fix(file): consistent function renderer in file functions tab #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions bsimvis/app/static/file/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,24 +406,12 @@
const cls = (f.clusters || []).map(uuid => clusters[uuid]).filter(Boolean);
const clusterCardHtml = window.EntityRenderer ? window.EntityRenderer.renderClusterCard(cls) : '';

// Details URL
let poolId = null;
if (window.getRoutingState && window.getRoutingState().pool) {
poolId = window.getRoutingState().pool;
}
let detailUrl = `/collections/${encodeURIComponent(fColl)}/files/${file_md5}/functions/${entry}`;
if (poolId) {
detailUrl = `/pools/${encodeURIComponent(poolId)}` + detailUrl;
}

return `
<tr class="sim-row" style="font-size: 0.75rem;" data-id="${funcId}"
data-entity-data='${JSON.stringify(f).replace(/'/g, "&apos;")}'
oncontextmenu="typeof EntityRenderer !== 'undefined' && EntityRenderer.handleContextMenu(event, 'function', this)">
<td>
<a href="${detailUrl}" onclick="event.preventDefault(); (window.Nav || window.parent.Nav).openPath('${detailUrl}', event);" style="color:var(--accent); font-weight:bold; text-decoration:none;">
${funcName}
</a>
<td style="min-width: 300px;">
${window.EntityRenderer ? window.EntityRenderer.renderFunction(f, { hideNote: true }) : funcName}
</td>
<td class="mono" style="color:var(--accent);">@ ${entry}</td>
<td>${tagsHtml}</td>
Expand Down