vysion: lazy-import Vysion deps to work around Python 3.13/3.14 import failures#778
Merged
adulau merged 1 commit intoMay 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
vysionimports cause import-time failures on Python 3.13/3.14 (likely due to a transitive dependency such assoftenum), breaking module registration; the change defers those imports so the package can load on all supported runtimes and fail gracefully at runtime when used.Description
vysionimports and add a_load_vysion_dependencies()helper that importsvysion.clientandvysion.dto.util.MISPProcessorlazily and raises a clearRuntimeErroron failure._load_vysion_dependencies()insidehandler()so the module only requiresvysionat runtime when actually invoked.RuntimeErrorhandling path with an actionable message, and broaden the generic exception handling to avoid relying on provider-specific exception classes during import-time failures.Testing
python -m py_compile misp_modules/modules/expansion/vysion.py, which succeeded.misp_modules/modules/expansion/vysion.pyand that the module now reports a clear runtime error ifvysion(or its transitive deps) cannot be imported.Codex Task