-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/dependency #3
base: master
Are you sure you want to change the base?
Conversation
Thanks! @LimHyungTae for the last commit (#2) we can instead use the latest version of catch2 catchorg/Catch2#2178 to fix it. Let me do that real quick. |
Okay @LimHyungTae I pushed a new commit to master with the latest Catch2 (v2 instead of v3 to keep compatibility). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have two comments.
cmake/eigen.patch
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this patch file for?
tests/catch.hpp
Outdated
@@ -10818,6 +10818,8 @@ PVOID FatalConditionHandler::exceptionHandlerHandle = nullptr; | |||
|
|||
#elif defined( CATCH_CONFIG_POSIX_SIGNALS ) | |||
|
|||
#undef MINSIGSTKSZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this if after you test with the latest Catch2 the error disappears.
Yay! Finally we become Regarding the patch, I just brought the patch from KISS-ICP, and they said it's to support BLAS and LAPACK options (see PRBonn/kiss-icp#329), but it might not be necessary. In addition to those things, Pybinding is really annoying, haha. I confess how it actually works in details, so there are some redundant parts. |
spark_robin sounds great! Thanks for the note on the patch & testing it in docker. |
This pull request includes several changes to the CMake build system, Python bindings, and documentation. The most important changes focus on updating dependencies, improving the build process, and restructuring the Python bindings.
Build System Updates:
CMakeLists.txt
.USE_SYSTEM_EIGEN3
to use a pre-installed Eigen library and added a custom function to handle external dependencies inCMakeLists.txt
andcmake/DownloadExternal.cmake
. [1] [2]find_package(Eigen3)
withfind_external_dependency
to fetch Eigen3 if not available in the system inCMakeLists.txt
.Python Bindings:
BUILD_PYTHON_BINDINGS
option and related code fromCMakeLists.txt
, and updated the Python bindings build process to usepybind11
andscikit-build
inpython/CMakeLists.txt
. [1] [2]pyproject.toml
for Python build system configuration, specifying dependencies and build backend.Documentation:
README.md
to reflect changes in the build process, including new installation instructions and updated CMake options. [1] [2]These changes aim to modernize the build process, simplify dependency management, and improve the overall maintainability of the project.
Dear @jingnanshi , could you check the last commit? I wanted to tackle #2. Happy to discuss how to resolve that issue!