Minor modifications for better usuability #184
Conversation
|
Also, I want to change |
|
I also enable getting normal vectors, which is the side-output of the procedure of FPFH. By doing so, the TEASER++ library can be more easily integrated with ROBIN |
|
Also, I fix the equal error in #177 |
| @@ -11,6 +11,7 @@ | |||
| #include <boost/smart_ptr/shared_ptr.hpp> | |||
| #include <pcl/features/fpfh.h> | |||
| #include <pcl/features/fpfh_omp.h> | |||
| #include <pcl/features/normal_3d_omp.h> | |||
There was a problem hiding this comment.
Is this header always there? Will there be any PCL installation that does not have this header?
There was a problem hiding this comment.
I double-checked it, and I found that it is stabilized since PCL 1.8 version as follow:
https://github.com/PointCloudLibrary/pcl/releases/tag/pcl-1.8.1
Thus, I think it's fine because in our CMakelLists.txt, we mention "1.8" version when finding the package.
In addition, until the latest version (1.14), the PCL library still supports normal_3d_omp as follows:
https://pcl-docs.readthedocs.io/en/latest/api/program_listing_file_pcl_features_include_pcl_features_normal_3d_omp.h.html
teaser/src/fpfh.cc
Outdated
| @@ -59,3 +59,5 @@ void teaser::FPFHEstimation::compute(pcl::PointCloud<pcl::FPFHSignature33>& outp | |||
| fpfh_estimation_->compute(output_cloud); | |||
| } | |||
| void teaser::FPFHEstimation::setRadiusSearch(double r) { fpfh_estimation_->setRadiusSearch(r); } | |||
|
|
|||
| pcl::PointCloud<pcl::Normal> teaser::FPFHEstimation::getNormals() { return *normals_; } | |||
There was a problem hiding this comment.
need to add a new line at the end of the file (I think clang format can do this automatically?)
There was a problem hiding this comment.
Yes, there's
InsertFinalNewline: 'yes'
option. May I add that option to .clang_format and add an additional line for all files?
There was a problem hiding this comment.
But I've noticed that other files also have no blank line; could you tell me why the new line at the end is needed?
There was a problem hiding this comment.
Yes about clang format. If the other files do not have newline character at the end, then we should also add them. See https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
|
All good except the missing new line character |
|
I did not know the importance of the new line at the end of the files. Here are my modifications:
|
|
@LimHyungTae thanks! merging |
Hello @jingnanshi , I'd like to do PR.
I modified two things:
Matcherclass