Feature/pypi #196
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| [build-system] | ||
| requires = ["scikit_build_core", "pybind11"] | ||
| build-backend = "scikit_build_core.build" | ||
|
|
||
| [project] | ||
| name = "teaserpp_python" | ||
| version = "1.1.0" | ||
| description = "Python binding for TEASER++" | ||
| readme = "README.md" | ||
| authors = [ | ||
| { name = "Jingnan Shi", email = "[email protected]" }, | ||
| ] | ||
| keywords = [ | ||
| "Point cloud", | ||
| "Registration", | ||
| "Non-minimal solver", | ||
| "Solver", | ||
| ] | ||
| classifiers = [ | ||
| "Intended Audience :: Developers", | ||
| "Intended Audience :: Education", | ||
| "Intended Audience :: Other Audience", | ||
| "Intended Audience :: Science/Research", | ||
| "License :: OSI Approved :: MIT License", | ||
| "Operating System :: MacOS", | ||
| "Operating System :: Microsoft :: Windows", | ||
| "Operating System :: Unix", | ||
| "Programming Language :: C++", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| ] | ||
| dependencies = [ | ||
| "numpy", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/MIT-SPARK/TEASER-plusplus" | ||
|
|
||
| [tool.scikit-build] | ||
| build-dir = "build/{wheel_tag}" | ||
| build.verbose = false | ||
| cmake.version = ">=3.16" | ||
| wheel.install-dir = "teaserpp_python.libs" | ||
|
|
||
| [tool.cibuildwheel] | ||
| archs = ["auto64"] | ||
| skip = ["*-musllinux*", "pp*", "cp36-*"] | ||
|
|
||
| [tool.cibuildwheel.macos] | ||
| environment = "MACOSX_DEPLOYMENT_TARGET=10.14" | ||
| archs = ["auto64", "arm64"] | ||
|
|
||
| [tool.pyright] | ||
| venvPath = "." | ||
| venv = ".venv" | ||
|
|
||
| typeCheckingMode = "standard" | ||
| reportUnusedImport = "none" | ||
| reportUnusedFunction = "none" | ||
| reportUnusedVariable = "none" | ||
| reportUndefinedVariable = "none" | ||
|
|
||
|
|
||
| [tool.ruff] | ||
| # Exclude a variety of commonly ignored directories. | ||
| exclude = [ | ||
| ".bzr", | ||
| ".direnv", | ||
| ".eggs", | ||
| ".git", | ||
| ".git-rewrite", | ||
| ".hg", | ||
| ".ipynb_checkpoints", | ||
| ".mypy_cache", | ||
| ".nox", | ||
| ".pants.d", | ||
| ".pyenv", | ||
| ".pytest_cache", | ||
| ".pytype", | ||
| ".ruff_cache", | ||
| ".svn", | ||
| ".tox", | ||
| ".venv", | ||
| ".vscode", | ||
| "__pypackages__", | ||
| "_build", | ||
| "buck-out", | ||
| "build", | ||
| "dist", | ||
| "node_modules", | ||
| "site-packages", | ||
| "venv", | ||
| ] | ||
|
|
||
| # Same as Black. | ||
| line-length = 88 | ||
| indent-width = 4 | ||
|
|
||
| # Assume Python 3.9 | ||
| target-version = "py39" | ||
|
|
||
| [tool.ruff.lint] | ||
| # Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default. | ||
| # Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or | ||
| # McCabe complexity (`C901`) by default. | ||
| select = ["E", "F", "I001"] | ||
| ignore = [] | ||
|
|
||
| # Allow fix for all enabled rules (when `--fix`) is provided. | ||
| fixable = ["ALL"] | ||
| unfixable = [] | ||
|
|
||
| # Allow unused variables when underscore-prefixed. | ||
| dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$" | ||
|
|
||
| [tool.ruff.format] | ||
| # Like Black, use double quotes for strings. | ||
| quote-style = "double" | ||
|
|
||
| # Like Black, indent with spaces, rather than tabs. | ||
| indent-style = "space" | ||
|
|
||
| # Like Black, respect magic trailing commas. | ||
| skip-magic-trailing-comma = false | ||
|
|
||
| # Like Black, automatically detect the appropriate line ending. | ||
| line-ending = "auto" | ||
|
|
||
| # Enable auto-formatting of code examples in docstrings. Markdown, | ||
| # reStructuredText code/literal blocks and doctests are all supported. | ||
| # | ||
| # This is currently disabled by default, but it is planned for this | ||
| # to be opt-out in the future. | ||
| docstring-code-format = false | ||
|
|
||
| # Set the line length limit used when formatting code snippets in | ||
| # docstrings. | ||
| # | ||
| # This only has an effect when the `docstring-code-format` setting is | ||
| # enabled. | ||
| docstring-code-line-length = "dynamic" | ||
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "basedpyright>=1.22.0", | ||
| "ruff>=0.8.1", | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,37 @@ | ||
| from enum import IntEnum | ||
| from typing import NamedTuple | ||
|
|
||
| from ._teaserpp import ( | ||
| OMP_MAX_THREADS, | ||
| CertificationResult, | ||
| DRSCertifier, | ||
| EigSolverType, | ||
| InlierGraphFormulation, | ||
| InlierSelectionMode, | ||
| RegistrationSolution, | ||
| RobustRegistrationSolver, | ||
| RotationEstimationAlgorithm, | ||
| ) | ||
|
|
||
| # Backwards compatibility with v1.0 so we don't break code | ||
| RobustRegistrationSolver.ROTATION_ESTIMATION_ALGORITHM = RotationEstimationAlgorithm | ||
| RobustRegistrationSolver.INLIER_SELECTION_MODE = InlierSelectionMode | ||
| RobustRegistrationSolver.INLIER_GRAPH_FORMULATION = InlierGraphFormulation | ||
| DRSCertifier.EIG_SOLVER_TYPE = EigSolverType | ||
|
|
||
|
|
||
| class RobustRegistrationSolverParams(NamedTuple): | ||
| noise_bound: float = 0.01 | ||
| cbar2: float = 1 | ||
| estimate_scaling: bool = True | ||
| rotation_estimation_algorithm: RotationEstimationAlgorithm = RotationEstimationAlgorithm.GNC_TLS | ||
| rotation_gnc_factor: float = 1.4 | ||
| rotation_max_iterations: int = 100 | ||
| rotation_cost_threshold: float = 1e-6 | ||
| rotation_tim_graph: InlierGraphFormulation = InlierGraphFormulation.CHAIN | ||
| inlier_selection_mode: InlierSelectionMode = InlierSelectionMode.PMC_EXACT | ||
| kcore_heuristic_threshold: float = 0.5 | ||
| use_max_clique: bool = True | ||
| max_clique_exact_solution: bool = True | ||
| max_clique_time_limit: int = 3000 | ||
| max_clique_num_threads: int = OMP_MAX_THREADS |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just curious; is
compile_commands.jsonneeded to support pip installation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is not. The compile flags just are convenient for development. The C++ linters and LSPs can use them to locate included libraries like pybind and Eigen so I don't get a billion errors everywhere and can get completion from the included libraries. I use
clangdas my LSP so it's just helpful for me. I'm not sure if VSCode or other IDEs have more automatic detection. I'm just using a barebones setup with Neovim and their built-in LSP/linting support.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your kind answer. I thought
compile_commands.jsonwas needed pip3. But isn't can be produced by-DCMAKE_EXPORT_COMPILE_COMMANDS=1?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can yeah. I think when building with
scikit-buildit was easier just to put it in the file since I had to figure out a way to pass it through in the pyproject file. We could probably put a switch there where they aren't made during release builds.