avoid log errors when type is missing but config is initialized #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmluk
approved these changes
Nov 13, 2024
| @@ -206,13 +206,14 @@ void declare_config(VirtualConfig<BaseT>& config) { | |||
| auto data = internal::Visitor::visitVirtualConfig(config.isSet(), config.optional_, config.getType()); | |||
|
|
|||
| // If setting values create the wrapped config using the string identifier. | |||
| const bool type_optional = config.optional_ || config.config_; | |||
There was a problem hiding this comment.
Would it make sense to add a brief comment which case is handled here (for future reference)? I think this does the right thing but not immediately clear to me when reading that the config being set makes it optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak to avoid the logger complaining when a virtual config is default initialized but not specified in the YAML config being loaded