Fix lab1 dense layer output assertion#118
Open
prashantkhurana wants to merge 1 commit intoMITDeepLearning:masterfrom
Open
Fix lab1 dense layer output assertion#118prashantkhurana wants to merge 1 commit intoMITDeepLearning:masterfrom
prashantkhurana wants to merge 1 commit intoMITDeepLearning:masterfrom
Conversation
prashantkhurana
changed the title
prashantkhurana
force-pushed
the
lab-1-assert
branch
from
f4301e7 to
35eafb4
Compare
1) tf.random.set_seed only sets the global seed https://www.tensorflow.org/api_docs/python/tf/random/set_seed 2) we need to set keras set_random_seed to make all seeds be deterministic. docs : https://www.tensorflow.org/api_docs/python/tf/config/experimental/enable_op_determinism, https://www.tensorflow.org/api_docs/python/tf/keras/utils/set_random_seed. enable_op_determinism might not be needed here but its good to have. fixes MITDeepLearning#116
prashantkhurana
force-pushed
the
lab-1-assert
branch
from
35eafb4 to
bff95a7
Compare
jacmacmod
approved these changes
Apr 8, 2023
dominikhaska
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lab1 assertion dense layer output assertion :
tf.random.set_seed only sets the global seed https://www.tensorflow.org/api_docs/python/tf/random/set_seed
we need to set keras set_random_seed to make all seeds be deterministic.
docs : https://www.tensorflow.org/api_docs/python/tf/config/experimental/enable_op_determinism, https://www.tensorflow.org/api_docs/python/tf/keras/utils/set_random_seed.enable_op_determinism might not be needed here but its good to have.
Fixes #116