Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update string in XML template #274

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Update string in XML template #274

merged 1 commit into from
Jan 23, 2025

Conversation

ehanson8
Copy link
Contributor

Purpose and background context

Small label change requested by stakeholders

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

@ehanson8 ehanson8 merged commit e6797be into main Jan 23, 2025
3 checks passed
@ehanson8 ehanson8 deleted the update-xml-template-string branch January 23, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghukill ghukill ghukill approved these changes

@jonavellecuerdo jonavellecuerdo Awaiting requested review from jonavellecuerdo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehanson8 @ghukill