Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rails 2.27.0 → 2.29.1 (minor) #1403

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 26, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.27.0 → 2.29.1) · Repo · Changelog

Release Notes

2.29.1

Bug fixes

  • #1423: Fix an error for Rails/StrongParametersExpect when using permit with no arguments. (@koic)
  • #1417: Fix an incorrect autocorrect for Rails/StrongParametersExpect when using a leading dot multiline call to require with permit. (@koic)
  • #1356: Enhance Rails/DuplicateAssociation to handle alias. (@ydakuka)
  • #1389: Handle TypeError caused by passing array literals as arguments to File methods in Rails/FilePath cop. (@ydakuka)
  • #1389: Handle TypeError caused by passing array literals as arguments to File methods in Rails/RootPathnameMethods cop. (@ydakuka)
  • #1228: Enhance Rails/SaveBang to properly handle instance variables. (@ydakuka)

2.29.0

New features

  • #1407: Add new Rails/MultipleRoutePaths cop. (@koic)
  • #1358: Add new Rails/StrongParametersExpect cop. (@koic)

Bug fixes

  • #1409: Fix an error for Rails/ReversibleMigration when calling drop_table without any arguments. (@earlopain)
  • #1397: Fix an incorrect autocorrect for Rails/TimeZone when Time.new has a string argument. (@mterada1228)
  • #1406: Fix autocorrection for Rails/IndexBy and Rails/IndexWith when map { ... }.to_h is enclosed in another block. (@franzliedke, @eugeneius)
  • #1404: Update Rails/IndexBy and Rails/IndexWith to support numbered block parameters. (@eugeneius)
  • #1405: Fix autocorrection for Rails/IndexWith when the value is a hash literal without braces. (@koic, @eugeneius)
  • #1414: Fix Rails/HttpPositionalArguments cop false positives with arguments forwarding. (@viralpraxis)

Changes

  • #1410: Make registered cops aware of AllCops: MigratedSchemaVersion. (@koic)

2.28.0

New features

  • #1383: Introduce AllCops: MigratedSchemaVersion config. (@koic)

Bug fixes

  • #1390: Fix an incorrect autocorrect for Rails/SelectMap when select has no receiver and method chains are used. (@masato-bkn)
  • #1382: Fix false negatives for Rails/RedundantActiveRecordAllMethod when using all method in block. (@masato-bkn)
  • #1397: Fix Rails/FilePath cop error on join method with implicit receiver. (@viralpraxis)
  • #1398: Fix Rails/FilePath cop error in case of extra operations in Rails.root interpolation. (@viralpraxis)
  • #1392: Fix Rails/FilePath cop error with rescued Rails.root. (@viralpraxis)

Changes

  • #1388: Modify Rails/Pluck to ignore map/collect when used inside blocks to prevent potential N+1 queries. (@masato-bkn)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.69.2 → 1.71.2) · Repo · Changelog

Release Notes

1.71.2

Bug fixes

  • #13782: Fix an error Layout/ElseAlignment when else is part of a numblock. (@earlopain)
  • #13395: Fix a false positive for Lint/UselessAssignment when assigning in branch and block. (@pCosta99)
  • #13783: Fix a false positive for Lint/Void when each numblock with conditional expressions that has multiple statements. (@earlopain)
  • #13787: Fix incorrect autocorrect for Style/ExplicitBlockArgument when using arguments of zsuper in method definition. (@koic)
  • #13785: Fix Style/EachWithObject cop error in case of single block argument. (@viralpraxis)
  • #13781: Fix a false positive for Lint/UnmodifiedReduceAccumulator when omitting the accumulator in a nested numblock. (@earlopain)

1.71.1

Bug fixes

  • #10081: Add the missing include RuboCop::RSpec::ExpectOffense in rubocop/rspec/support.rb. (@d4rky-pl)
  • #13765: Fix a false negative for Lint/AmbiguousBlockAssociation with numblocks. (@earlopain)
  • #13759: Fix a false negative for Lint/ConstantDefinitionInBlock with numblocks. (@earlopain)
  • #13741: Register an offense for Naming/BlockForwarding and Style/ArgumentsForwarding with Ruby >= 3.4 when the block argument is referenced inside a block. This was previously disabled because of a bug in Ruby 3.3.0. (@earlopain)
  • #13777: Fix a false negative for Layout/EmptyLineBetweenDefs with DefLikeMacros and numblocks. (@earlopain)
  • #13769: Fix a false negative for Style/RedundantParentheses with numblocks. (@earlopain)
  • #13780: Fix a false positive Style/AccessModifierDeclarations when using access modifier in a numblock. (@earlopain)
  • #13775: Fix a false positive for Lint/AssignmentInCondition when assigning in numblocks. (@earlopain)
  • #13773: Fix false positives for Layout/RedundantLineBreak when using numbered block parameter. (@koic)
  • #13761: Fix a false positive for Style/SuperArguments when calling super in a numblock. (@earlopain)
  • #13768: Fix a false positive for Lint/UnreachableCode with instance_eval numblock. (@earlopain)
  • #13750: Fix false positives for Style/RedundantSelfAssignment when assigning to attribute of self. (@koic)
  • #13739: Fix false positive for Style/HashExcept and Style/HashSlice when checking for inclusion with a range. (@dvandersluis)
  • #13751: Fix false positive in Layout/ExtraSpacing with ForceEqualSignAlignment: true for endless methods. (@dvandersluis)
  • #13767: Fix Style/IdenticalConditionalBranches autocorrect when condition is inside assignment. (@dvandersluis)
  • #13764: Fix a false negative for Layout/SingleLineBlockChain with numblocks. (@earlopain)
  • #13771: Fix wrong autocorrect for Style/SoleNestedConditional when using numblocks. (@earlopain)

1.71.0

New features

Bug fixes

  • #13684: Fix a false positive for Style/FrozenStringLiteralComment when using the frozen string literal magic comment in Active Admin's arb files. (@koic)
  • #13372: Add rubocop_cache to the path given by --cache-root when pruning cache. (@capncavedan)
  • #13257: Fix department disable/enable comments enabling the cop for the whole file even if that file is excluded by the cop. (@earlopain)
  • #13704: Fix false positives for Lint/OutOfRangeRegexpRef when matching with match using safe navigation. (@koic)
  • #13720: Fix false positives for Style/BlockDelimiters when using brace blocks as conditions under EnforcedStyle: semantic. (@koic)
  • #13688: Fix false negative on Style/RedundantLineContinuation when the continuation is preceded by an interpolated string. (@dvandersluis)
  • #13677: Fix false negative on Style/RedundantLineContinuation when the continuation is followed by a percent array. (@dvandersluis)
  • #13692: Fix false positive in Style/RedundantLineContinuation when the ruby code ends with a commented continuation. (@dvandersluis)
  • #13675: Fix invalid autocorrect for Style/ArrayFirstLast when calling .[] or &.[] with 0 or -1. (@dvandersluis)
  • #13685: Fix syntax error introduced by Lint/SafeNavigationChain when adding safe navigation to an operator call inside a hash. (@dvandersluis)
  • #13725: Fix an incorrect autocorrect for Style/IfUnlessModifier when using omitted hash values in an assignment. (@elliottt)
  • #13667: Maintain precedence in autocorrect for Style/SoleNestedConditional. (@tejasbubane)
  • #13679: Fix false positive for Style/RedundantLineContinuation when calling methods with fully qualified constants. (@earlopain)
  • #13728: Fix a RuboCop error on provided glob pattern which matches directory. (@viralpraxis)
  • #13693: Fix Style/ConditionalAssignment cop error on unless without else and assign_inside_condition enforced style. (@viralpraxis)
  • #13669: Fix Style/FrozenStringLiteralComment cop error on unnormalized magic comment and never enforced style. (@viralpraxis)
  • #13696: Update Metrics/CollectionLiteralLength to only register for [] when called on Set. (@dvandersluis)

Changes

1.70.0

New features

  • #13474: Add new Style/ItAssignment cop to detect local assignments to it inside blocks. (@dvandersluis)
  • #11013: Add new Lint/SharedMutableDefault cop to alert on mutable Hash defaults. (@corsonknowles)
  • #13612: Create new cop Lint/ConstantReassignment. (@lovro-bikic)
  • #13628: Make LSP server support quick fix code action. (@koic)
  • #13607: Support passing the target ruby version through an environment variable. (@elliottt)
  • #13628: Add support for Ruby LSP as a built-in add-on. (@koic)
  • #13284: Add new target_gem_version API to change behavior of a cop at runtime depending on which gem version is present. (@earlopain)

Bug fixes

  • #13589: Fix Lint/NonAtomicFileOperation to detect offenses with fully qualified constants. (@viralpraxis)
  • #13630: Fix CLI --format option to accept fully qualified formatter class names. (@viralpraxis)
  • #13624: Don't show warnings from Lint/Syntax when a syntax error occurs. (@earlopain)
  • #13605: Fix RuboCop::Cop::Util.to_string_literal to work correctly with frozen strings. (@viralpraxis)
  • #12393: Fix false negatives for Lint/Void inside of non-modifier conditionals. (@GabeIsman)
  • #13623: Fix false negatives for Style/MultipleComparison when setting AllowMethodComparison: false and comparing with simple method calls. (@koic)
  • #13644: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when an access modifier and an expression are on the same line. (@koic)
  • #13645: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and last argument is an endless range. (@earlopain)
  • #13614: Fix false positives for Style/RaiseArgs with anonymous splat and triple dot forwarding. (@earlopain)
  • #13591: Fix false positives for Lint/NestedMethodDefinition when defining a method on a constant or a method call. (@koic)
  • #13594: Fix false positives for Style/MultipleComparison when using multiple safe navigation method calls. (@koic)
  • #13654: Fix false positives for Style/RedundantInitialize when empty initialize method has arguments. (@marocchino)
  • #13608: Fix crash when running rubocop -d on a config with a remote inherit_from that causes a duplicate setting warning. (@dvandersluis)
  • #12430: Fix false negatives in Style/RedundantLineContinuation with multiple line continuations. (@dvandersluis)
  • #13638: Fix false positive for Naming/BlockForwarding when method just returns the block argument. (@mvz)
  • #13599: Fix incorrect autocorrect for Layout/HashAlignment when there is a multiline positional argument and Layout/ArgumentAlignment is configured with EnforcedStyle: with_fixed_indentation. (@dvandersluis)
  • #13586: Fix regression in Layout/SpaceAroundOperators when different comparison operators were aligned with each other. (@dvandersluis)
  • #13603: Fix Lint/LiteralInInterpolation cop error on invalid string literal. (@viralpraxis)
  • #13582: Fix Lint/NonAtomicFileOperation cop error on non-constant receiver. (@viralpraxis)
  • #13598: Fix Lint/Void cop error on if without body. (@viralpraxis)
  • #13634: Fix Style/ClassAndModuleChildren cop error on compact enforced style and unindented body. (@viralpraxis)
  • #13642: Fix Style/FloatDivision cop error if #to_f has implicit receiver. (@viralpraxis)
  • #13517: Fixes Style/HashExcept to recognize safe navigation when ActiveSupportExtensionsEnabled config is enabled. (@lovro-bikic)
  • #13585: Fix Style/HashSyntax cop error on implicit call method. (@viralpraxis)
  • #13632: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains elsif. (@viralpraxis)
  • #13659: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains multiple elsif. (@viralpraxis)
  • #13596: Fix Style/RedundantCondition cop error on parentheses and modifier if in else. (@viralpraxis)
  • #13616: Fix incorrect autocorrect for Style/RedundantRegexpArgument when the regex contains a single quote. (@mrzasa)
  • #13619: Fix Style/YodaExpression cop error in case of suffix form of operator. (@viralpraxis)
  • #13578: Update Layout/LineContinuationSpacing to ignore continuations inside a regexp or xstr. (@dvandersluis)
  • #13601: Update Style/SuperArguments to handle super with a block or with a chained method with a block. (@dvandersluis)
  • #13568: Fix NoMethodError in ConfigValidator when a Cop's config is not a Hash and raise ValidationError instead. (@amomchilov)

Changes

  • #13665: Add support for safe navigation to Style/ObjectThen. (@dvandersluis)
  • #13657: Add support for safe navigation to Layout/HashAlignment. (@dvandersluis)
  • #13656: Add support for safe navigation to Layout/HeredocArgumentClosingParenthesis. (@dvandersluis)
  • #13655: Add support for safe navigation to Layout/LineLength. (@dvandersluis)
  • #13662: Add support for safe navigation to Style/SendWithLiteralMethodName. (@dvandersluis)
  • #13557: Fix false positives for Lint/NumericOperationWithConstantResult. (@earlopain)
  • #13658: Fix invalid autocorrect for Style/SlicingWithRange when calling .[] or &.[] with a correctable range. (@dvandersluis)
  • #13548: Enhance Lint/DuplicateSetElement to detect offences within SortedSet. (@viralpraxis)
  • #13646: Update Layout/TrailingWhitespace to support blank characters other than space and tab. (@krororo)
  • #13652: Update Metrics/MethodLength to make use of AllowedMethods and AllowedPatterns for methods defined dynamically with define_method. (@dvandersluis)
  • #13606: Update Style/AccessModifierDeclarations to add AllowModifiersOnAliasMethod configuration (default true). (@dvandersluis)
  • #13662: Update Style/RedundantSelfAssignment to handle safe navigation on the right-hand side of the assignment. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ bigdecimal (indirect, 3.1.8 → 3.1.9) · Repo · Changelog

Release Notes

3.1.9 (from changelog)

  • Accept no digits in the fractional part (#302)

    @kou

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.9.1 → 2.10.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ language_server-protocol (indirect, 3.17.0.3 → 3.17.0.4) · Repo · Changelog

Release Notes

3.17.0.4 (from changelog)

  • Add #close to Reader and Writer (#112)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ logger (indirect, 1.6.3 → 1.6.5) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ parser (indirect, 3.3.6.0 → 3.3.7.1) · Repo · Changelog

Release Notes

3.3.7.1 (from changelog)

API modifications:

  • parser/current: add -dev prefix to 3.4 branch (#1067) (Ilya Bylich)
  • parser/current: bump 3.2 branch to 3.2.7 (#1066) (Ilya Bylich)

3.3.7.0 (from changelog)

API modifications:

  • Bump maintenance branches to 3.3.7 (#1061) (Koichi ITO)
  • bump 3.4 branch, remove 3.0 from CI (EOL) (#1057) (Ilya Bylich)
  • assert that version-specific checks actually run against at least one version (#1050) (Earlopain)

Features implemented:

  • ruby34.y: reject return in singleton class (#1048) (Earlopain)

Bugs fixed:

  • Fix ruby-parse with a folder ending in .rb (#1047) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.9.3 → 2.10.0) · Repo · Changelog

Release Notes

2.10.0 (from changelog)

Added

  • #referenced_expressions
    • like #referenced_expression, but for multiplexing backrefs
    • returns the Group expressions that are being referenced

Fixed

  • fixed #char & #codepoint errors for single-digit hex escapes
    • e.g. \xA

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.37.0 → 1.38.0) · Repo · Changelog

Release Notes

1.38.0 (from changelog)

New features

  • #346: Add Node#loc? to determine if a node has a given location. (@dvandersluis)
  • #356: Added :any_block as an alias for :block and :numblock, use it with Node#any_block_type?. Also available in node patterns: {block numblock} can become any_block. (@earlopain)

Bug fixes

  • #323: Fix node captures inside of ?, +, and * repetition. (@earlopain)

Changes

  • #357: Support node groups in Node#each_descendant and similar traversal methods. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ unicode-display_width (indirect, 2.6.0 → 3.1.4) · Repo · Changelog

Release Notes

3.1.4 (from changelog)

  • Fix that skin tone modifiers were ignored when used in a non-ZWJ sequence context (= single emoji char + modifier) #29
  • Add more docs and specs about modifier handling

3.1.3 (from changelog)

Better handling of non-UTF-8 strings, patch by @Earlopain:

  • Data with BINARY encoding is interpreted as UTF-8, if possible
  • Use invalid: :replace and undef: :replace options when converting to UTF-8

3.1.2 (from changelog)

  • Performance improvements

3.1.1 (from changelog)

  • Performance improvements

3.1.0 (from changelog)

Improve Emoji support:

  • Emoji modes: Differentiate between well-formed Emoji (:possible) and any ZWJ/modifier sequence (:all). The latter is more common and more efficient to implement.
  • Unify rgi_{fqe,mqe,uqe} options to just :rgi to keep things simpler (corresponds to the former :rgi_uqe option). Most terminals that want to support the RGI set will probably want to catch Emoji sequences with missing VS16s.
  • Add new :all_no_vs16 and :rgi_at modes to be able to support some terminals that needs these quirks
  • Add alias emoji: :auto for emoji: true and emoji: :none for emoji: false
  • :auto mode: Only consider terminal cells when recommending Emoji support level (Emoji themselves might display differently)
  • :auto mode: Set default Emoji mode for unknown/unsupported terminals to :none
  • Rename :basic mode to :vs16

3.0.1 (from changelog)

  • Add WezTerm and foot as good Emoji terminals

3.0.0 (from changelog)

Rework Emoji support:

  • Emoji widths are now enabled by default
  • Only reduce Emoji width to 2 when RGI Emoji detected (configurable)
  • VS16 turns Emoji characters of width 1 into full-width
  • Please note that Emoji parsing has a notable impact on performance. You can use the emoji: false option to disable Emoji adjustments
  • Tries to detect terminal's Emoji support level automatically (from ENV vars)

Index fixes and updates:

  • Private-use characters are considered ambiguous (were given width 1 before)
  • Fix that a few zero-width ignorable codepoints from recent Unicode were missing
  • Consider the following separators to be zero-width:
    • U+2028 - LINE SEPARATOR - Zl
    • U+2029 - PARAGRAPH SEPARATOR - Zp

Other:

  • Add keyword arguments to Unicode::DisplayWidth.of. If you are using a hash with overwrite values as third parameter, be sure to put it in curly braces.
  • Using third parameter or explicit hash as fourth parameter is deprecated, please migrate to the keyword arguments API
  • Gem raises ArgumentError for ambiguous values other than 1 or 2
  • Performance optimizations
  • Require Ruby 2.5

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 unicode-emoji (added, 4.0.4)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 26, 2025
@mitlib mitlib temporarily deployed to mit-bento-pr-1403 January 26, 2025 05:17 Inactive
@depfu depfu bot force-pushed the depfu/update/rubocop-rails-2.29.1 branch from 50f7c39 to 6129563 Compare February 10, 2025 16:50
Copy link
Contributor Author

depfu bot commented Feb 10, 2025

Closing because this update has already been applied

@depfu depfu bot closed this Feb 10, 2025
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.29.1 branch February 10, 2025 18:48
@coveralls
Copy link

Coverage Status

coverage: 99.07%. remained the same
when pulling 6129563 on depfu/update/rubocop-rails-2.29.1
into c5a0637 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants