Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README re: environment variables #584

Closed
wants to merge 3 commits into from
Closed

Update README re: environment variables #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b29234
Update README re: environment variables
cjwetherington Dec 11, 2024
0e81e2d
add trailing comma to tuple
cjwetherington Dec 11, 2024
3e576fd
update readme re- envs
cjwetherington Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ WORKSPACE=dev
RECORD_SKIP_LIST=<oai-pmh-id1> <oai-pmh-id2>

# Sets the interval for logging status updates as records are written to the output file. Defaults to 1000, which will log a status update for every thousandth record.
STATUS_UPDATE_INTERVAL = 1000
STATUS_UPDATE_INTERVAL=1000

# If set to a valid Sentry DSN, enables Sentry exception monitoring This is not needed for local development.
SENTRY_DSN = <sentry-dsn-for-oai-pmh-harvester>
# If set to a valid Sentry DSN, enables Sentry exception monitoring. This can also be set to 'none'.
SENTRY_DSN=<sentry-dsn-for-oai-pmh-harvester>
```

## CLI commands
Expand Down
4 changes: 2 additions & 2 deletions harvester/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@


class Config:
REQUIRED_ENV_VARS = ("WORKSPACE", "SENTRY_DSN")
OPTIONAL_ENV_VARS = ("RECORD_SKIP_LIST", "STATUS_UPDATE_INTERVAL")
REQUIRED_ENV_VARS = ("WORKSPACE",)
OPTIONAL_ENV_VARS = ("RECORD_SKIP_LIST", "SENTRY_DSN", "STATUS_UPDATE_INTERVAL")

def __init__(self, logger: logging.Logger | None = None):
"""Set root logger as default when creating class instance."""
Expand Down
Loading