Remove SENTRY_DSN from required env vars #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
For local development, or external users of this application, it does not make sense to require a
SENTRY_DSN
environment variable. While setting this to 'none' would satisfy the config setup, and not use Sentry, it feels unnecessary.How this addresses that need:
SENTRY_DSN
to optional env vars inConfig
classNOTE: this PR ports the code changes from another PR #584 (thanks @cjwetherington!), which we were unable to merge at the time for unrelated CI/CD reasons.
How can a reviewer manually see the effects of these changes?
1- unset
SENTRY_DSN
as environment variable2- The following should show CLI help, where formerly this would throw a required env var error:
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO: SENTRY_DSN is no longer required as an env var, but providing it will still get picked up used
What are the relevant tickets?
Developer
Code Reviewer(s)