Rename and update tests for Record methods

MITLibraries · May 9, 2024 · cf9c2a5 · cf9c2a5
1 parent 3bbfe64
commit cf9c2a5
Showing 1 changed file with 21 additions and 35 deletions.
diff --git a/solenoid/records/tests/test_models.py b/solenoid/records/tests/test_models.py
@@ -75,7 +75,7 @@ def test_get_missing_citation_fields_returns_missing_minimal_citation_fields(sel
             f"missing required fields to generate minimal citation: ['{Fields.TITLE}', '{Fields.JOURNAL}']."
         )
 
-    def test_is_record_creatable_returns_true_if_required_fields_present(self):
+    def test_is_record_creatable_acq_method_not_fpv_returns_true(self):
         # Data includes the basics? Good!
         data = {
             Fields.PUBLISHER_NAME: "foo",
@@ -84,46 +84,32 @@ def test_is_record_creatable_returns_true_if_required_fields_present(self):
         }
         assert Record.is_record_creatable(data)
 
-    def test_is_record_creatable_returns_false(self):
+    def test_is_record_creatable_acq_method_unknown_returns_true(self):
         data = {
             Fields.PUBLISHER_NAME: "foo",
             Fields.ACQ_METHOD: "",
             Fields.CITATION: "nonempty",
         }
-        print(Record.is_record_creatable(data))
         assert Record.is_record_creatable(data)
-        assert 1 / 0
-
-        # # missing citation fields is okay
-        # data = copy.copy(self.paper_data)
-        # data.update(self.citation_data)
-        # data[Fields.CITATION] = ""
-        # data[Fields.FIRST_NAME] = ""
-        # assert Record.is_record_creatable(data)
-
-        # data = {
-        #     Fields.PUBLISHER_NAME: "foo",
-        #     # No acq method column at all
-        #     Fields.CITATION: "nonempty",
-        # }
-        # assert not Record.is_record_creatable(data)
-
-        # # RECRUIT_FROM_AUTHOR_FPV requires a DOI.
-        # data = {
-        #     Fields.PUBLISHER_NAME: "foo",
-        #     Fields.ACQ_METHOD: "RECRUIT_FROM_AUTHOR_FPV",
-        #     Fields.CITATION: "nonempty",
-        #     Fields.DOI: "",
-        # }
-        # assert not Record.is_record_creatable(data)
-
-        # data = {
-        #     Fields.PUBLISHER_NAME: "foo",
-        #     Fields.ACQ_METHOD: "RECRUIT_FROM_AUTHOR_FPV",
-        #     Fields.CITATION: "nonempty",
-        #     Fields.DOI: "4217896",
-        # }
-        # assert Record.is_record_creatable(data)
+
+    def test_is_record_creatable_acq_method_fpv_returns_true(self):
+        data = {
+            Fields.PUBLISHER_NAME: "foo",
+            Fields.ACQ_METHOD: "RECRUIT_FROM_AUTHOR_FPV",
+            Fields.CITATION: "nonempty",
+            Fields.DOI: "4217896",
+            Fields.PUBLISHER_NAME: "nonempty",
+        }
+        assert Record.is_record_creatable(data)
+
+    def test_is_record_creatable_acq_method_fpv_returns_false(self):
+        data = {
+            Fields.PUBLISHER_NAME: "foo",
+            Fields.ACQ_METHOD: "RECRUIT_FROM_AUTHOR_FPV",
+            Fields.CITATION: "nonempty",
+            Fields.DOI: "",
+        }
+        assert not Record.is_record_creatable(data)
 
     def test_is_valid_fpv_but_no_doi(self):
         record = Record.objects.get(pk=1)