-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance updates #473
Maintenance updates #473
Conversation
Why these changes are being introduced: * Implement minor maintenance updates as part of Heroku software updates (Heroku stack and Redis). How this addresses that need: * Update Python version to 3.12 * Update Python dependencies * Update README Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1075
a2e5f88
to
a6b2956
Compare
fcbaa05
to
3fcabee
Compare
3fcabee
to
ee1bdee
Compare
Note: We are waiting to hear back from @JPrevost to confirm that disabling SSL checks is okay for this application. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns on my end but just commenting until Jeremy's approval is confirmed so the PR isn't accidentally merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! The discussion continues outside of this PR about some intricacies of how and when the SSL errors are bubbling up, but given it's working in staging with these changes, pushing to production to test there would be beneficial.
Purpose and background context
Implement minor maintenance updates as part of Heroku software updates (Heroku stack and Redis).
This PR serves as a way to maintain the standard deployment workflow for Heroku apps (i.e.,
PR creates review app, merging PR deploys to staging, and a
promote to production
via Heroku Dashboard).Regarding the second commit for disabling SSL certificates:
This change was required by the upgrade of Redis from version 6.2.14 to 7.2.
This instructs Celery to not verify the Redis broker URL.
Update the base Django settings file to append "?ssl_cert_reqs=none" at the end of the
CELERY_BROKER_URL
config variable and update the default broker url to use "rediss" syntax to accept appended syntax.How can a reviewer manually see the effects of these changes?
ruff
is not included at this time).Includes new or updated dependencies?
YES - Updated to use Python 3.12.
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)