Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance updates #473

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

jonavellecuerdo
Copy link
Contributor

@jonavellecuerdo jonavellecuerdo commented Oct 17, 2024

Purpose and background context

Implement minor maintenance updates as part of Heroku software updates (Heroku stack and Redis).
This PR serves as a way to maintain the standard deployment workflow for Heroku apps (i.e.,
PR creates review app, merging PR deploys to staging, and a promote to production via Heroku Dashboard).

Regarding the second commit for disabling SSL certificates:
This change was required by the upgrade of Redis from version 6.2.14 to 7.2.

  1. What does this do?
    This instructs Celery to not verify the Redis broker URL.
  2. What are the changes?
    Update the base Django settings file to append "?ssl_cert_reqs=none" at the end of the CELERY_BROKER_URL config variable and update the default broker url to use "rediss" syntax to accept appended syntax.

How can a reviewer manually see the effects of these changes?

  1. Confirm linters pass (Note: ruff is not included at this time).
  2. Confirm all unit tests are passing.
  3. Review sample email sent to Solenoid Admins. Look for subject heading: "OA outreach message to forward: "

Includes new or updated dependencies?

YES - Updated to use Python 3.12.

Changes expectations for external applications?

NO

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed or provided examples verified
  • New dependencies are appropriate or there were no changes

Why these changes are being introduced:
* Implement minor maintenance updates as part of
Heroku software updates (Heroku stack and Redis).

How this addresses that need:
* Update Python version to 3.12
* Update Python dependencies
* Update README

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1075
@jonavellecuerdo jonavellecuerdo self-assigned this Oct 17, 2024
@mitlib mitlib temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 14:55 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 15:00 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 16:05 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 16:05 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 16:23 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 16:24 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 16:57 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 17:03 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 17:03 Inactive
@jonavellecuerdo jonavellecuerdo force-pushed the IN-1075-update-heroku-stack-and-redis branch from a2e5f88 to a6b2956 Compare October 17, 2024 17:20
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 17:21 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 17:21 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 17:26 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 17:28 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 17:53 Inactive
@jonavellecuerdo jonavellecuerdo force-pushed the IN-1075-update-heroku-stack-and-redis branch from fcbaa05 to 3fcabee Compare October 17, 2024 18:14
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 18:14 Inactive
@jonavellecuerdo jonavellecuerdo force-pushed the IN-1075-update-heroku-stack-and-redis branch from 3fcabee to ee1bdee Compare October 17, 2024 18:19
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-in-1075-up-pzty2e October 17, 2024 18:19 Inactive
@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging October 17, 2024 18:21 Inactive
@jonavellecuerdo
Copy link
Contributor Author

Note: We are waiting to hear back from @JPrevost to confirm that disabling SSL checks is okay for this application. 🤔

Copy link
Contributor

@ehanson8 ehanson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns on my end but just commenting until Jeremy's approval is confirmed so the PR isn't accidentally merged

Copy link
Contributor

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! The discussion continues outside of this PR about some intricacies of how and when the SSL errors are bubbling up, but given it's working in staging with these changes, pushing to production to test there would be beneficial.

@jonavellecuerdo jonavellecuerdo merged commit a75a408 into main Oct 17, 2024
2 checks passed
@jonavellecuerdo jonavellecuerdo deleted the IN-1075-update-heroku-stack-and-redis branch October 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants