Use timdex-dataset-api v0.9.0 and remove temporary code #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * As of v0.9.0, TDA accepts filtering fields using 'or' conditions, allowing the removal of a temporary workaround in the helper method that checks for existence of records in a TIMDEXDataset post-filtering. How this addresses that need: * Remove temporary workaround * Update 'load' method to filter action using list of possible values Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-455
ghukill
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Cutting is delivering! Looks good. Thanks for knocking these out @jonavellecuerdo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Update
timdex-pipeline-lambdashelper functiondataset_records_exist_for_runto usetimdex-dataset-apiv0.9.0 and remove temporary workaround that uses low-level PyArrow dataset filtering.How can a reviewer manually see the effects of these changes?
See result of updates to
TIMDEXDataset._get_filtered_datasetin MITLibraries/timdex-dataset-api#99 (review)Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)