Skip to content

Conversation

@IvanaEscobar
Copy link
Contributor

@IvanaEscobar IvanaEscobar commented Jul 30, 2025

Updates CI for Python versions 3.11, 3.12, and 3.13:

  • GitHub Actions were deprecated v2/3 --> v4
  • specify zarr version, other test_env versions
  • removed versioneer and put setuptools-scm in place
  • fixed issue Python 3.13 incompatibility: del arg_values['frame'] #343
  • added regex string literals
  • commented out deprecated ECCO Portal paths
  • works with Codecov v4 Actions

@mjlosch
Copy link
Member

mjlosch commented Jul 30, 2025

@IvanaEscobar thanks for that! The CI tests are all passing now and we should merge this PR as soon as possible, so that other PRs can be tested and moved forward. This is a big step forward!

As I am no expert (neither python, CI, nor xmitgcm), I can only work on obvious bug fixes.

I will merge this tomorrow, if there are no objections.

@mjlosch
Copy link
Member

mjlosch commented Jul 30, 2025

also fixes issue #345

@mjlosch
Copy link
Member

mjlosch commented Aug 1, 2025

@IvanaEscobar do you have anything else to add, or should I try to merge this now?

@IvanaEscobar
Copy link
Contributor Author

@mjlosch it's ready for merging

@mjlosch
Copy link
Member

mjlosch commented Aug 4, 2025

@IvanaEscobar
In the notes it still says

NOTE: does not fix codecov

is that this valid after the lastest 3 commits?

@IvanaEscobar
Copy link
Contributor Author

Good catch, I updated the description to remove that note. Codecov works as long as there is a token provided as an Action Secret.

@mjlosch mjlosch merged commit 9cf83a5 into MITgcm:master Aug 4, 2025
4 checks passed
@IvanaEscobar IvanaEscobar deleted the ci-faclift branch August 5, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants