Skip to content

hotfix - docker 관련 수정 - #109

Merged
roode1017 merged 1 commit into
devfrom
hotfix/#108
Aug 20, 2025
Merged

hotfix - docker 관련 수정#109
roode1017 merged 1 commit into
devfrom
hotfix/#108

Conversation

@roode1017

@roode1017 roode1017 commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • 런타임 베이스 이미지를 경량 JRE로 전환하여 컨테이너 이미지 크기를 줄이고 배포/스케일링 속도를 개선했습니다. 경량 기반으로 메모리 사용량 감소와 시작 시간 단축이 기대됩니다.
    • API 서비스의 불필요한 의존성 대기 조건을 제거하여 기동 순서를 단순화했습니다. 그 결과, 서비스가 외부 컴포넌트 상태와 무관하게 더 빠르게 시작될 수 있어 초기 가용성이 향상됩니다.

@roode1017 roode1017 self-assigned this Aug 20, 2025
@roode1017 roode1017 added the bug Something isn't working label Aug 20, 2025
@roode1017 roode1017 linked an issue Aug 20, 2025 that may be closed by this pull request
@roode1017
roode1017 merged commit 411becc into dev Aug 20, 2025
1 check was pending
@coderabbitai

coderabbitai Bot commented Aug 20, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

  • backendProject/Dockerfile runtime base image changed from openjdk:17-jre-slim to eclipse-temurin:17-jre-alpine; formatting tweak added.
  • docker-compose-prod.yml: Removed mlb-kafka from depends_on for api1 and api2, eliminating health-based startup gating on mlb-kafka.

Changes

Cohort / File(s) Summary
Runtime 이미지 업데이트
backendProject/Dockerfile
런타임 단계 베이스 이미지를 Debian 기반 JRE에서 Alpine 기반 eclipse-temurin JRE로 변경. 기타 단계는 동일. 공백 라인 추가.
Compose 의존성 조정
docker-compose-prod.yml
services.api1.depends_onservices.api2.depends_on에서 mlb-kafka: condition: service_healthy 제거. 다른 의존성은 유지.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant DC as docker-compose
  participant API1 as api1
  participant API2 as api2
  participant KAFKA as mlb-kafka

  Note over DC: 변경 전
  DC->>KAFKA: 시작
  DC->>API1: mlb-kafka healthy 대기 후 시작
  DC->>API2: mlb-kafka healthy 대기 후 시작

  rect rgba(230,245,255,0.5)
  Note over DC: 변경 후
  DC->>KAFKA: 시작 (독립)
  DC->>API1: 즉시(다른 의존성 기준) 시작
  DC->>API2: 즉시(다른 의존성 기준) 시작
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

알파인 바람에 JRE가 살짝,
토끼는 컨테이너 위로 깡충 깡충.
카프카 기다림은 이제는 끝,
API 둘이 먼저 출발, 쓩—쓩!
배포 들판에 파란 파도, 빌드엔 평온만 남았지. 🐇🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 06484ec and 26c46c0.

📒 Files selected for processing (2)
  • backendProject/Dockerfile (1 hunks)
  • docker-compose-prod.yml (0 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/#108

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roode1017
roode1017 deleted the hotfix/#108 branch August 20, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hotfix - compose, dockerfile 수정

1 participant