Conversation
Elasticsearch 의존성 제거
시간이 지나면 자동으로 드래프트를 생성하고, 생성한 내용을 바탕으로 사용자들의 페이지를 이동 시킴
통합 후 수정 작업 진행중
드래프트 생성 참가자 배정 채팅방 생성
Feature/#43 선수 검색 기능 추가
배포를 위한 docker-compose 파일 추가 및 securityConfig 수정, deploy 파일 추가
|
Caution Review failedThe pull request is closed. Walkthrough메인/테스트/인프라 전반에 걸친 대규모 변경. 배포 워크플로우 추가, Docker Compose(prod) 도입, 드래프트 실시간 처리 로직을 서비스/STOMP 중심으로 재구성, WebSocket JWT 인증 도입 및 매치 타임아웃/배정 기능 추가, 선수 캐시+Elasticsearch 검색 계층 추가, 시즌 누적 점수 집계 도입, 보안/Redis/Kafka 설정 조정, 헬스체크/테스트 환경 업데이트. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant STOMP as STOMP Broker
participant DraftCtrl as DraftController
participant DraftSvc as DraftService
participant Redis as Redis Pub/Sub
participant Sub as RedisSubscriber
Client->>STOMP: SEND /app/draft/selectPlayer (DraftRequest)
STOMP->>DraftCtrl: dispatch selectPlayer()
DraftCtrl->>DraftSvc: selectPlayer(draftRequest, principal)
DraftSvc->>Redis: publish room.{draftId} (JSON)
Redis-->>Sub: message (DraftRequest)
Sub->>STOMP: convertAndSend /topic/draft.{draftId}
STOMP-->>Client: MESSAGE (DraftRequest payload)
sequenceDiagram
participant Scheduler as MatchScheduler(5s)
participant Timing as DraftTimingService
participant Processor as MatchTimeoutProcessor
participant Repo as JPA Repos
participant WS as MatchHandler
Scheduler->>Timing: getNextDraftWindowOrThrow()
Scheduler->>Processor: processTimeoutAndInsert()
Processor->>Repo: create Draft/Participants (real/dummy)
Processor-->>Scheduler: Map<userId, AssignDto>
loop for each user
Scheduler->>WS: notifyDraftStart(userId, draftId, userNumber)
WS-->>User: DRAFT_START message
end
sequenceDiagram
participant Browser
participant WS as WebSocket Server
participant Auth as AuthHandshakeHandler
participant JWT as JwtTokenProvider
participant Sec as SecurityContext
Browser->>WS: Handshake /ws/match?token=Bearer xxx
WS->>Auth: determineUser()
Auth->>Sec: has Authentication?
alt none
Auth->>JWT: validate + getAuthentication(token)
JWT-->>Auth: Authentication
end
Auth-->>WS: Principal or null
WS-->>Browser: Accept or Reject
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90+ minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (58)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Feature/#43 선수 포지션 리스트 가져오기 기능 개발 및 선수 검색 기능 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git action 관련 추가
docker-compse 추가
http response를 위한 controller 추가 입니다
Summary by CodeRabbit
신규 기능
변경
작업