Skip to content

deploy 테스트 - #83

Merged
roode1017 merged 4 commits into
mainfrom
dev
Aug 20, 2025
Merged

deploy 테스트#83
roode1017 merged 4 commits into
mainfrom
dev

Conversation

@roode1017

@roode1017 roode1017 commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • 신기능
    • 드래프트 참가자 목록에 “현재 사용자” 표시가 추가되어 본인 식별 및 하이라이트가 가능합니다.
    • 로그인한 사용자 기준으로 참가자 데이터가 반영되어 보다 개인화된 목록을 제공합니다.
    • 포지션별 최소/최대 선발 인원 정보가 노출되어 베스트 일레븐 구성 시 가이드 및 유효성 검사가 용이해졌습니다.
  • 기타(Chores)
    • 배포 워크플로가 main 대상 PR에서도 실행되도록 트리거를 확장했습니다.

@roode1017 roode1017 self-assigned this Aug 20, 2025
@roode1017 roode1017 added the enhancement New feature or request label Aug 20, 2025
@coderabbitai

coderabbitai Bot commented Aug 20, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

  • Draft 참가자 조회 API에 인증 사용자 컨텍스트를 도입해 userEmail을 전달하고 DTO에 userFlag를 포함하도록 매핑 변경.
  • ElementType DTO에 squadMinPlay/squadMaxPlay 필드 추가 및 매핑 확장.
  • CI: deploy 워크플로우가 main 대상 PR에서도 실행되도록 트리거 추가.

Changes

Cohort / File(s) Change summary
Draft 참가자 인증 컨텍스트 도입
backendProject/.../draft/controller/DraftController.java, backendProject/.../draft/service/DraftService.java, backendProject/.../match/entity/Participant.java, backendProject/.../draft/dto/DraftParticipant.java
Controller에 @AuthenticationPrincipal 추가 및 서비스 시그니처 getParticipantsByDraftId(UUID, String)로 변경. Participant의 DTO 변환 메서드가 userEmail 인자를 받아 userFlag를 설정. DraftParticipant DTO에 userFlag 필드 추가.
ElementType DTO 확장
backendProject/.../player/dto/ElementTypeDto.java, backendProject/.../player/entity/ElementType.java
DTO에 squadMinPlay, squadMaxPlay 필드 추가. Entity→DTO 매핑에서 두 필드 빌더 매핑 추가.
CI 워크플로우 트리거
.github/workflows/deploy.yml
pull_request 트리거(main 대상) 추가. 기존 단계 변경 없음.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 사용자
  participant API as DraftController
  participant Auth as SecurityContext
  participant Svc as DraftService
  participant Repo as Draft/Participant Store
  participant Map as Participant.toDtoList

  User->>API: GET /api/draft/{draftId}/participants
  API->>Auth: 인증 사용자 조회(@AuthenticationPrincipal)
  Auth-->>API: CustomUserDetails(userEmail)
  API->>Svc: getParticipantsByDraftId(draftId, userEmail)
  Svc->>Repo: 드래프트 및 참가자 조회
  Repo-->>Svc: List<Participant>
  Svc->>Map: toDtoList(participants, userEmail)
  Map-->>Svc: List<DraftParticipant{..., userFlag}]
  Svc-->>API: List<DraftParticipant>
  API-->>User: 200 OK (JSON)
  note over Map,User: userEmail 일치 시 해당 항목의 userFlag=true
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • hwichoi0317
  • Kim-Jaehyun0328
  • wjkim9

Poem

풋풋 튀는 발자국, 깡총깡총 실행돼요 🐇
main을 향한 PR에도, 배포 방울 딸랑딸랑—
내 메일 맞으면 귀가 쏙, userFlag 반짝!
스쿼드엔 최소·최대, 포지션이 착착.
밤새 코드 뜯던 토끼, 오늘도 빌드 성공! ✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8333410 and 895f844.

📒 Files selected for processing (7)
  • .github/workflows/deploy.yml (1 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/controller/DraftController.java (2 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/dto/DraftParticipant.java (1 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/service/DraftService.java (1 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/match/entity/Participant.java (1 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/player/dto/ElementTypeDto.java (1 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/player/entity/ElementType.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roode1017
roode1017 merged commit 4cd645a into main Aug 20, 2025
1 check was pending
@coderabbitai coderabbitai Bot mentioned this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants