Skip to content

hotfix - deploy 수정 - #88

Merged
roode1017 merged 1 commit into
devfrom
hotfix/#87
Aug 20, 2025
Merged

hotfix - deploy 수정#88
roode1017 merged 1 commit into
devfrom
hotfix/#87

Conversation

@roode1017

@roode1017 roode1017 commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • 배포 워크플로우 단순화: CI에서 JDK/Gradle 빌드 제거, 업로드 대상을 프로젝트 소스와 환경 파일 중심으로 조정.
    • 배포 시 원격 .env 생성 단계 제거하고, 제공된 .env 사용으로 일관성 강화.
    • Docker/Compose 설치 및 실행 절차 정리, 컨테이너 정리 동작 유지.
  • 기타
    • CloudFront 캐시 무효화 단계의 순서와 라벨 정리.
    • 안내 문구 일부 표현 개선으로 가독성 향상.

@roode1017 roode1017 self-assigned this Aug 20, 2025
@roode1017 roode1017 added the bug Something isn't working label Aug 20, 2025
@roode1017 roode1017 linked an issue Aug 20, 2025 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 20, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

GitHub Actions 배포 워크플로(.github/workflows/deploy.yml)를 수정하여 JDK/Gradle 빌드와 JAR 업로드를 제거하고, 프로젝트 소스(docker-compose-prod.yml, .env 포함)를 EC2로 전송해 Docker Compose로 배포하도록 변경. 원격 .env 생성 단계 제거, CloudFront 무효화 단계 번호 조정, 경미한 문구 수정.

Changes

Cohort / File(s) Change Summary
CI 빌드 단계 제거
.github/workflows/deploy.yml
JDK 설정 및 Gradle 빌드 단계 삭제.
아티팩트 전송 경로 변경
.github/workflows/deploy.yml
전송 대상을 backendProject/**, docker-compose-prod.yml, .env로 조정. backendProject/Dockerfile 및 build/libs/*.jar 전송 제거.
.env 처리 방식 변경
.github/workflows/deploy.yml
원격 서버에서 .env 생성(cat/EOF) 단계 삭제; 로컬에서 전달된 .env 사용.
Docker/Compose 동작 유지
.github/workflows/deploy.yml
Docker/Compose 설치(없으면) 유지, docker compose down/build/up 및 컨테이너 정리 절차 유지.
CloudFront 단계 번호 조정
.github/workflows/deploy.yml
선택 단계 번호 “6)” → “4)”로 변경, 명칭 조정.
문구 정리
.github/workflows/deploy.yml
“설치(없을 때)” → “설치 (없으면)” 등 경미한 텍스트 수정.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub Actions
  participant EC2 as EC2 Host
  participant DC as Docker Compose
  participant CF as CloudFront (optional)

  Dev->>GH: push/tag (workflow dispatch)
  GH->>EC2: SSH 접속
  GH->>EC2: 프로젝트 전송 (backendProject/**, docker-compose-prod.yml, .env)
  GH->>EC2: Docker/Compose 설치 확인/설치
  GH->>DC: docker compose down
  GH->>DC: docker compose build
  GH->>DC: docker compose up -d
  alt 선택: 캐시 무효화
    GH->>CF: Invalidate distribution
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

  • hotfix - deploy 또 수정 #84 — 동일 파일(.github/workflows/deploy.yml)의 배포 플로우와 .env/아티팩트 전송 방식 변경과 직접적으로 연관됨.

Possibly related PRs

Poem

토끼는 깡충, 배포는 경쾌
빌드는 가볍게, JAR는 안녕해 🐇
.env는 포근히 함께 건너가고,
compose는 척척 배를 띄워 주네.
바람 솔솔, 캐시도 훅— 비워 주면,
오늘도 초록 버튼, 평온한 저녁!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fc9a7ae and f41b967.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml (3 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/#87

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roode1017
roode1017 merged commit 1b406b6 into dev Aug 20, 2025
1 check was pending
@roode1017
roode1017 deleted the hotfix/#87 branch August 20, 2025 06:01
@coderabbitai coderabbitai Bot mentioned this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hotfix - deploy 또 또 변경

1 participant