Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit pages #14

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Conversation

p0nch000
Copy link
Contributor

@p0nch000 p0nch000 commented Oct 2, 2024

Add Education Section to Resume Builder

Features Added

  • Implemented Education section in the Resume Builder app
  • Added state management for Education entries
  • Created EducationView component to display existing education entries
  • Implemented EducationForm component for adding new education entries
  • Added EducationEditPage component for editing existing education entries
  • Integrated Education components into the main App component
  • Maintained existing Skills section functionality
  • Added button group for toggling Education add and edit forms

Changes

  • Updated App component to include Education section
  • Added state variables for managing Education data and UI states:
    • education: Array to store education entries
    • showEducationForm: Boolean to toggle add education form visibility
    • showEducationEditPage: Boolean to toggle edit education page visibility
  • Implemented handler functions for Education-related actions:
    • handleAddEducationClick: Toggles add education form
    • handleEducationFormSubmit: Adds new education entry to state
    • toggleEducationEditPage: Toggles edit education page
    • handleEducationUpdate: Updates education entries in state

Pending Tasks

  • Implement backend PUT request for updating education entries
  • Implement backend POST request for adding new education entries
  • Add form validation for education inputs
  • Implement error handling for education-related API calls
  • Add unit tests for new Education components and functions

Screenshots

Captura de pantalla 2024-10-01 a la(s) 11 11 55 p m Captura de pantalla 2024-10-01 a la(s) 10 56 28 a m Captura de pantalla 2024-10-01 a la(s) 10 56 02 a m

Closes #16 #4 #10 #3

@p0nch000
Copy link
Contributor Author

p0nch000 commented Oct 7, 2024

@yashika51 its not letting me ask for a review, but I have finally passed the tests, this PR is ready

Copy link
Collaborator

@yashika51 yashika51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Go ahead and merge it

@p0nch000
Copy link
Contributor Author

p0nch000 commented Oct 9, 2024

@yashika51 solved merge conflicts but I cannot merge cause of write access, can you help me pls??

@yashika51 yashika51 merged commit bd764f8 into MLH-Fellowship:main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants