Migrate osm opening hours parsing to external library #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Afaik Android officially still only supports JUnit 4 as a testing library, so I'm fine with that.
Oh no! :D I'd like to publish a release today, so this will probably have to wait for the next version if that's alright? |
Sure, no problem. I'm not in a hurry :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #860.
I have also added tests with JUnit. Not sure if you'd still want new test implementations to base on a Java-only testing library, but I figured since e.g. tests of
:core:ktxalso use JUnit I'd use that.There are some TODOs left because I somehow underestimated how big of a raging dumpster fire the
opening_hoursspec actually is. ("sunrise to sunset" is a thing!)