Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): pin matplotlib<=3.9.4 for now #238

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

wpbonelli
Copy link
Contributor

Some of the example scripts have begun to break with matplotlib 3.10. Most of the failures are due to the removal of the collections attribute from ContourSet and related API changes. We will need to rewrite some things to work around this. For reference see the corresponding change from a while ago in flopy.

Two failures however seem to be internal to matplotlib, with pillow being used incorrectly:

Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/matplotlib/animation.py", line 224, in saving
      yield self
    File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/matplotlib/animation.py", line 1126, in save
      writer.grab_frame(**savefig_kwargs)
    File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/matplotlib/animation.py", line 499, in grab_frame
      self._frame.append(im)
  AttributeError: 'PillowWriter' object has no attribute '_frame'. Did you mean: '_frames'?

While we address the former and wait for a resolution for the latter, we can just pin mpl.

@wpbonelli wpbonelli merged commit b2f22aa into MODFLOW-USGS:develop Dec 17, 2024
10 checks passed
@wpbonelli wpbonelli deleted the ci branch December 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant