Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prp): support coordinate transformations #1901

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jun 26, 2024

Previously PRT required particle release points (except for z via LOCAL_Z) to be specified in the model coordinate system, and reported pathlines in the same coordinate system. This PR enables input coordinate transformations with keyword options for the PRP (particle release point) package.

With this change, points may be specified as

  • model coordinates (default, as before)
  • local cell coordinates scaled to the unit interval with LOCAL_XY and/or LOCAL_Z — only structured grids
  • offsets from the cell center, no rescaling, via LOCAL_XY_OFFSET — structured or unstructured grids
  • global coordinates via dev option DEV_GLOBAL_XY — transform release points to model coordinates using grid georeference information

Checklist of items for pull request

  • Added new test or modified an existing test
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated definition files
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

@wpbonelli
Copy link
Contributor Author

wpbonelli commented Jun 26, 2024

@langevin-usgs this is generally according to our outline with the main difference being MODEL_XY and conditioning the release point transform on grid offset/rotation, probably good to chat again switched to DEV_GLOBAL_XY as discussed offline and updated description above.

@wpbonelli wpbonelli force-pushed the prt-local branch 3 times, most recently from f7b8c52 to 0cb9b66 Compare June 28, 2024 03:16
@wpbonelli wpbonelli marked this pull request as ready for review June 28, 2024 12:08
@wpbonelli
Copy link
Contributor Author

This should be ready for a look when @aprovost-usgs is back

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there may be more on work on this, but just wanted to mention one comment about the release notes. I'm good with whatever you and @aprovost-usgs decide on the coordinate options.

doc/ReleaseNotes/develop.tex Outdated Show resolved Hide resolved
@wpbonelli wpbonelli marked this pull request as draft July 9, 2024 12:00
wpbonelli added a commit that referenced this pull request Nov 11, 2024
…#2055)

Carved out of #1901 for tidiness. Split TrackDataModule into TrackFileModule and TrackControlModule. Also clean up some comments, and pass fmi down into cell/subcell tracking methods (not always needed, but best to be consistent).
@wpbonelli wpbonelli marked this pull request as ready for review November 12, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants