-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prp): support coordinate transformations #1901
base: develop
Are you sure you want to change the base?
Conversation
@langevin-usgs this is generally according to our outline |
f7b8c52
to
0cb9b66
Compare
This should be ready for a look when @aprovost-usgs is back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there may be more on work on this, but just wanted to mention one comment about the release notes. I'm good with whatever you and @aprovost-usgs decide on the coordinate options.
Previously PRT required particle release points (except for z via
LOCAL_Z
) to be specified in the model coordinate system, and reported pathlines in the same coordinate system. This PR enables input coordinate transformations with keyword options for the PRP (particle release point) package.With this change, points may be specified as
LOCAL_XY
and/orLOCAL_Z
— only structured gridsLOCAL_XY_OFFSET
— structured or unstructured gridsDEV_GLOBAL_XY
— transform release points to model coordinates using grid georeference informationChecklist of items for pull request
fprettify