Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions of fzp and fzm, units of Coriolis parameter, tend_ru_physics, height vars in Registry files #1093

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

theweathermanda
Copy link
Contributor

@theweathermanda theweathermanda commented Jun 28, 2023

I've removed "linear" from the descriptions for fzp and fzm to be consistent with new option to either interpolate linearly or via a layer integration. I've also corrected the units for fVertex and fEdge, and the units for dzu, rdzu, and dzw, which were all listed as unitless.

I've removed "linear" from the descriptions for fzp and fzm to be consistent with new option to either interpolate linearly or via a layer integration
I've removed "linear" from the descriptions for fzp and fzm to be consistent with new option to either interpolate linearly or via a layer integration
@theweathermanda theweathermanda marked this pull request as draft June 28, 2023 20:59
@theweathermanda theweathermanda marked this pull request as ready for review June 28, 2023 21:22
The units of Coriolis parameter are s^{-1}. I've corrected these for fVertex and fEdge
The units of Coriolis parameter are s^{-1}. I've corrected these for fVertex and fEdge
@theweathermanda theweathermanda changed the title Update descriptions of fzp and fzm in init_atmosphere and atmosphere core Registry files Update descriptions of fzp and fzm, units of Coriolis parameter vars in Registry files Jun 29, 2023
The units of tend_ru_physics were erroneously listed as kg m^{-2} s^{-1}. I've changed them to be consistent with the units of coupled horizontal momentum tendency, or  kg m^{-2} s^{-2}
@theweathermanda theweathermanda changed the title Update descriptions of fzp and fzm, units of Coriolis parameter vars in Registry files Update descriptions of fzp and fzm, units of Coriolis parameter vars, tend_ru_physics in Registry files Jun 29, 2023
These variables were previously listed as unitless although they have units of either height (m) or inverse height
These variables were previously listed as unitless although they have units of either height (m) or inverse height
@theweathermanda theweathermanda changed the title Update descriptions of fzp and fzm, units of Coriolis parameter vars, tend_ru_physics in Registry files Update descriptions of fzp and fzm, units of Coriolis parameter, tend_ru_physics, height vars in Registry files Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant