Enable GPU exection of summarize_timestep via OpenACC #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mestep These 'integer, pointer' variables are used as loop bounds and can cause issues with OpenACC. Since OpenACC will directly copy the pointers and may not preserve the association (may not also copy the value pointed to), odd behavior can result.
This prevents having to add OpenACC routine information to mpas_log_write and routine(s) it calls.
Only for loops executed when 'config_print_detailed_minmax_vel = .true.' When running with OpenACC, it is difficult to get values to "come with" during a reduction. This means it's difficult to get both the minimum value of an array and the position (the array indices) it occurs at in one pass. Using 2 loops like this ensures the correct positions are found. Using a "linear index" to record the position of the minimum/maximum values helps in cases where the min/max occurs at multiple points in an array. The detailed prints will always use the first occurence of the min/max in the array.
Adds timing information for the OpenACC data transfers in the 'summarize_timestep [ACC_data_xfer]' timer. This timer will be removed as data regions in the MPAS-A dycore are fused.
Adds timing information for the OpenACC data transfers in the temporary 'summarize_timestep [ACC_data_xfer]' timer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the code and adds OpenACC directives to allow the loops in the
summarize_timesteproutine can execute on GPUs.Timing information for the temporary OpenACC data transfers in this routine is captured in the log file by a new timer: 'summarize_timestep [ACC_data_xfer]'.
This PR includes a re-write of the loops associated with
config_print_detailed_minmax_velto ensure consistent locations are reported for the minimum and maximum values for the wind speeds.