Calculate killscore by kill assists, kills, deaths and HPs healed #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You just broke it again. It's fine if the maps commit is broken locally, the main repo knows which one to use You can fix it by rebasing and dropping the commit There are also conflicts with the PR again unfortunately |
|
@LoneWolfHT Ready to merge :) And let me know if you want it on the experimental server. |
|
@LoneWolfHT Status? |
|
You could run it on the test server, it'll be a while before I can review it |
|
This needs to be well-tested on a test server, or at least merged after a ranked reset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested several times. The current algorithm only counts kills and deaths. But we know kill assists are just as important. And a medic-knight combination can be very dangerous.