Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give way more score for killing a flag thief #1302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farooqkz
Copy link
Contributor

@farooqkz farooqkz commented Jun 10, 2024

  • This PR has been tested locally

The suggestion originates from here: https://discord.com/channels/447819017391046687/448136308108296213/1246872747838279710

The flag multiplier which multiplies the score is 1 for no flag, and multiplied by 2 for each flag added. Like 2 for a flag and 4 for two flags. Because it's way harder to not get killed and steal the second flag.

@LoneWolfHT
Copy link
Member

You need to test locally (self-review) before requesting a review

@farooqkz
Copy link
Contributor Author

Okay... I thought the change is trivial

@farooqkz
Copy link
Contributor Author

Self review done

@@ -191,7 +191,7 @@ local function calculate_killscore(player)
local flag_multiplier = 1
for tname, carrier in pairs(ctf_modebase.flag_taken) do
if carrier.p == player then
flag_multiplier = flag_multiplier + 0.25
flag_multiplier = flag_multiplier * 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is a literal exponential increase. For now I'd suggest this instead:

Suggested change
flag_multiplier = flag_multiplier * 2
flag_multiplier = flag_multiplier + 1

That should result in the score being the normal(?) kill score * the number of flags they have, starting at x2 for one flag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's an exponential increase. Getting flag of one team is not that hard. But getting flag of one team and at the same time getting flag of another one, is extremely hard. You have teammembers of the first team on your tail, everyone know your location every second, and then you have to approach base of another team to get their flag.

Therefore, I think exponential makes perfect sense.

Copy link
Member

@LoneWolfHT LoneWolfHT Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion is trying to encourage people to kill flag carriers, what you're saying is maybe justification for rewarding the flag carrier.

If this score increase isn't enough it could be changed to +2 or more, but I think a linear increase keeps the focus on killing "someone with a flag"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put it to a vote among players?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or otherwise ask for a third party opinion. Since I don't agree with you, a third party opinion helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants