Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent item's special ability from activating during build time. #1307

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mrtechtroid
Copy link
Contributor

@mrtechtroid mrtechtroid commented Jun 17, 2024

  • This PR has been tested locally
  • Based on suggestion Discord, now prevent users from activating diamond sword/granade/invincible mode during build time.

@LoneWolfHT
Copy link
Member

It'd probably be a good idea to add a HUD message saying you can't activate during build time. So as not to confuse new players trying to figure out abilities

@mrtechtroid
Copy link
Contributor Author

mrtechtroid commented Jun 25, 2024

done.

Copy link
Contributor

@farooqkz farooqkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on DRY rule, I suggest defining a new function somewhere and calling it from the 3 places.

@LoneWolfHT
Copy link
Member

I'm fine merging it without, up to techdroid

@mrtechtroid
Copy link
Contributor Author

Im fine with merging too. if its not a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants