Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug - Poison grenades deal no damage to enemies. #1312

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrtechtroid
Copy link
Contributor

@mrtechtroid mrtechtroid commented Jun 25, 2024

  • This PR has been tested locally
  • Due to damage amount being very low, 1 instead of 10, the poison grenade did not do damage at all to players.
  • Caused due to PR f847ac8

@LoneWolfHT
Copy link
Member

LoneWolfHT commented Jun 29, 2024

That's punch_interval, the damage is down where fleshy=1 is. Maybe that needs to be increased to 2? A punch interval of 1 should be fine, it's accurate too

@mrtechtroid
Copy link
Contributor Author

It does work(does damage as expected), when the punch_interval was increased to 10. However could you let me know of any alternative approaches to fix it.

@farooqkz
Copy link
Contributor

farooqkz commented Jun 29, 2024

hmm it works. Though I can't say why...

Copy link
Contributor

@farooqkz farooqkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@LoneWolfHT
Copy link
Member

It does work(does damage as expected), when the punch_interval was increased to 10. However could you let me know of any alternative approaches to fix it.

There might be an on_punchplayer or something that's ignoring 1hp damage with punch intervals of 1

What does 2hp of fleshy damage do?

@mrtechtroid
Copy link
Contributor Author

Yes, punch interval 1, with fleshy = 2 also works, in fixing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants