Use a modal to show sponsors #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterfarrell9
requested changes
Apr 17, 2023
Webpacker probably handles this already and serves the whole |
fosterfarrell9
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This adds a new feature: we now use a modal to show sponsors at
/#sponsors. Due to the newly introduced login/landing page in #444, we do not have a navbar anymore which led to an error since the sponsor route was previously accessible without authentication. However, in the new navbar, we do not even consider if the user is logged in anymore as the navbar is per se only shown when the user is logged in. A hotfix was employed in #461.Todo
Preview