Fix annotation status default value in UI #708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #704.
In reality, the default was indeed that the status is inherited from the lecture. You could even open a video and verify that users can create annotations and share them with the teacher.
The problem was that originally, Marlon used the values
-1, 0, 1
to signify:-1
: deactivated0
: inherit1
: activatedand I changed that to the following when I worked on the annotation tool:
-1
: inherit0
: deactivated1
: activatedHowever, I forgot to update the values at this place in the UI and therefore the wrong radio button was highlighted (the frontend got the value
-1
which meant deactivated beforehand).Luckily, this is a simple frontend bug and we don't have to update anything in the backend.