Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow display MaaCore Output real-time #374

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Jackhr-arch
Copy link

@Jackhr-arch Jackhr-arch commented Feb 23, 2025

本质就是把全局变量换成了一个管道

这个对 #322 应该也有些作用

目前是输出为String,并打印到stdout

大概是这样的效果

image

@wangl-cc
Copy link
Member

感谢贡献。我也打算把这个换成一个 Channel,不过最近我暂时没空 Review,我下周抽空看一下。

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 2.12766% with 92 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (779cd39) to head (2a16903).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/maa-cli/src/run/callback/summary.rs 3.57% 54 Missing ⚠️
crates/maa-cli/src/run/callback/mod.rs 0.00% 29 Missing ⚠️
crates/maa-cli/src/run/mod.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   66.28%   65.45%   -0.84%     
==========================================
  Files          42       42              
  Lines        3628     3673      +45     
==========================================
- Hits         2405     2404       -1     
- Misses       1223     1269      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants