-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 调整 Python Binding 初始化行为 #444
Closed
+22
−69
Closed
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
25dac22
chore: 调整 Python Binding 初始化行为
weinibuliu 79cf591
fix: 修复路径输出格式异常的问题
weinibuliu 5b0ae32
chore: 修复 binding test 不通过的问题;调整报错信息
weinibuliu ca12499
chore: 调整 Python Binding 初始化行为
weinibuliu a44595b
fix: 修复路径问题引起的异常
weinibuliu 9bc1a16
fix: 尝试调整 test.py
weinibuliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,18 @@ | ||
import os | ||
from pathlib import Path | ||
import sys | ||
|
||
from .library import Library | ||
|
||
__PATH = os.path.join(os.path.dirname(__file__), "bin") | ||
__PATH = Path(Path(__file__).parent, "bin") | ||
if not __PATH.exists(): | ||
# sys.argv is designed for Github Action,we seldom use this. | ||
if len(sys.argv) < 2: | ||
raise FileNotFoundError(f"`{__PATH}` is not existed.") | ||
|
||
if os.path.exists(__PATH): | ||
ver = Library.open(__PATH) | ||
if ver: | ||
print(f"MaaFw version: {ver}") | ||
__PATH = Path(Path(sys.argv[1]).resolve(), "bin") | ||
if not __PATH.exists(): | ||
raise FileNotFoundError(f"`{__PATH}` is not existed.") | ||
|
||
ver = Library.open(__PATH) | ||
if not ver: | ||
raise RuntimeError("Fail to open the library.") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initialized 这个变量看看能不能也删了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
或许是可以的,这个变量的用途应该只是在其他文件中检查 library 初始化状态,现在在初始化失败时直接 raise 了