Use C++ when checking for eigen (autotools) #3690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need gmake, so the default may not work on non-GNU systems, e.g., illumos. [ci skip]
|
I added another halfway-related commit, passing MAKE to the cddlib and givaro configure scripts. Both need gmake, and these scripts were failing when the default was illumos make. |
d-torrance
added
waiting for review
build issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with building Macaulay2 in OpenIndiana and was puzzled when it failed detecting eigen.
I checked out
config.logand noticed that the check failed when one of the eigen headers tried to#include <cmath>, and it couldn't find the file. It turns out that it was trying to compile usinggccinstead ofg++!It's a trivial fix, just adding
AC_LANG([C++]), so I'm skipping the builds.Cc: @MichaelABurr