Networking updates #3693
Draft
Networking updates #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added to the POSIX standard in 2001 and should be available on all modern systems. Since we no longer need to roll our own host_address, which used inet_addr, we can drop the check for arpa/inet.h.
The "PF" is for "protocol family" (AF is "address family"). According to the GNU libc manual: "The corresponding namespace designator symbol PF_UNSPEC exists for completeness, but there is no reason to use it in a program."
It was a thin wrapper around getaddrinfo that used a global variable to store the error message when an error was raised. This likely wasn't thread safe. Instead, we determine the error message a bit later, when it's time to actually print it, without any global variables. This requires a little bit of logic to distinguish between getaddrinfo errors and non-getaddrinfo errors. In particular, we shift the error codes of the getaddrinfo errors and then shift back later when we need them.
In particular: * Use memset to initialize the hints struct instead of static (for thread safety) * Actually use a hints struct in opensocket * Loop through all the elements of the linked list returned by getaddrinfo until we find one that works rather than just crossing our fingers and going with the first one * Use the info in the struct returned by getaddrinfo in our call to socket rather than hardcoding everything * With new for loop logic, we only need a single call to freeaddrinfo. Code heavily inspired by Beej's Guide to Network Programming: https://beej.us/guide/bgnet
The value of status will only be accurate if the process has changed state, i.e., if waitpid returned a positive value. So in particular, we won't be able to trust that fix_status will return -2 in this case as given in the documentation. So we return -2 manually in this case.
So many ternary conditional operators... Also put #ifdef's around the non-POSIX WCOREDUMP as recommended in the waitpid manpage.
Also remove some "is Error" cases -- user can't pass an Error!
Also add typical values
For the "method already installed" error message to look okay (i.e.,
not display "MutableHashTable{...}"), we turn nullaryMethods into a
Type, which kind of makes sense anyway since it's the object we
install these methods in.
Previously, something like openOutAppend "$localhost:12345" or openOutAppend "!cat" would cause us to write to files with these names rather than the expected behavior. The "Append" really doesn't mean anything -- behavior is identical to openOut in these cases.
d-torrance
force-pushed
the
getaddrinfo
branch
2 times, most recently
from
2365e64 to
c18ea36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking through our networking code while I work on the language server and have made a few changes:
#ifdef HAVE_functionclauses for networking functions that have been POSIX standard for over twenty years, so we remove those. We also remove a bunch of checks for functions that generated macros we weren't actually using.getaddrinfo, which previously used a global variable and I don't think it was thread safe and remove a few unused error handling functions.getaddrinfoand use the first one that works rather than just hoping that the very first one works.openOutAppendto sockets and pipes. It does the exact same thing asopenOut, but our current behavior for something likeopenOutAppend "$localhost:12345" << "Hello, world!" << closeis to actually write to a file named$localhost:12345rather than send a message to port 12345.This is a draft for now, as I'll probably do more with it (e.g., documentation).