This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
checking prepare_parts for mmcblk device & partition differences #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maccraft123
reviewed
Jul 28, 2021
bootfw/depthcharge/prepare_parts
Outdated
| ROOTPART=${DEVICE}3 | ||
|
|
||
| # resolves issue with mmcblk devices | ||
| if [[ $DEVICE == mmcblk* ]]; then |
There was a problem hiding this comment.
Maybe the check should be
if [ -e ${DEVICE}1 ]
to account for devices that are not mmcblk* and do use p to separate whole drive from single partitions
There was a problem hiding this comment.
@Maccraft123 not sure I follow but I have an updated commit where I switched to the single test expression (before I saw this).
I tested this. The logic is similar, we test for mmcblk devices and set the partitions accordingly. Otherwise we use the same values you used previous.
|
@Maccraft123 finally got this write. Had to put it at the end of the script after the partition creation. Tested. Can we merge ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will test on next build.