-
-
Notifications
You must be signed in to change notification settings - Fork 240
Fix: Add missing quotes to pip install #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add missing quotes to pip install #153
Conversation
WalkthroughUpdates CONTRIBUTING.md to quote the extras spec in the pip install command: from pip install -e .[dev] to pip install -e '.[dev]', adding a Linux/Mac note. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
44-48
: Add a Windows example and clarify the comment.Consider documenting cmd.exe usage alongside Linux/macOS/PowerShell to avoid confusion.
- pip install -e '.[dev]' # Linux/Mac + pip install -e '.[dev]' # Linux/macOS (bash/zsh) and Windows PowerShell + # Windows (cmd.exe): + pip install -e ".[dev]"Optional: prefer
python -m pip install -e ...
to ensure the right interpreter’s pip is used.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CONTRIBUTING.md
(1 hunks)
🔇 Additional comments (1)
CONTRIBUTING.md (1)
44-44
: LGTM: quoting fixes shell globbing.Good catch. Quoting the extras spec prevents bash/zsh pathname expansion and avoids accidental matches like .d/.e/.v.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 71.01% 71.01%
=======================================
Files 39 39
Lines 3171 3171
Branches 462 462
=======================================
Hits 2252 2252
Misses 807 807
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks @RadixSeven ! |
This is a pretty simple PR. On
bash
, I needed quotes for thepip install
(otherwise it's an expression that matches the files.d
,.e
, or.v
. I couldn't test it on Windows, however, so I added a comment marking this as a Linux/Mac.Summary by CodeRabbit