-
Notifications
You must be signed in to change notification settings - Fork 0
Add pyproject and CI wheel build configuration #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 issues found across 3 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| readme = "README.md" | ||
| license = {file = "LICENSE"} | ||
| requires-python = ">=3.8" | ||
| dependencies = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyYAML is imported but not declared as a dependency; add "pyyaml" to [project].dependencies to fix ModuleNotFoundError.
(Based on your team's feedback about pytest failing with ModuleNotFoundError: yaml.)
Prompt for AI agents
Address the following comment on pyproject.toml at line 18:
<comment>PyYAML is imported but not declared as a dependency; add "pyyaml" to [project].dependencies to fix ModuleNotFoundError.
(Based on your team's feedback about pytest failing with ModuleNotFoundError: yaml.)</comment>
<file context>
@@ -0,0 +1,25 @@
+[build-system]
+requires = [
+ "setuptools>=61",
+ "wheel",
+ "torch==2.1.0",
+ "triton==2.1.0",
+]
+build-backend = "setuptools.build_meta"
+
</file context>
pyproject.toml
Outdated
| "setuptools>=61", | ||
| "wheel", | ||
| "torch==2.1.0", | ||
| "triton==2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triton is listed in build requirements; move it to project dependencies to avoid heavyweight installs during build isolation.
Prompt for AI agents
Address the following comment on pyproject.toml at line 6:
<comment>Triton is listed in build requirements; move it to project dependencies to avoid heavyweight installs during build isolation.</comment>
<file context>
@@ -0,0 +1,25 @@
+[build-system]
+requires = [
+ "setuptools>=61",
+ "wheel",
+ "torch==2.1.0",
+ "triton==2.1.0",
+]
+build-backend = "setuptools.build_meta"
</file context>
pyproject.toml
Outdated
| requires = [ | ||
| "setuptools>=61", | ||
| "wheel", | ||
| "torch==2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyTorch is listed as a build requirement, which will trigger heavyweight installs in the isolated build env; keep build-system requires minimal (build tools only).
Prompt for AI agents
Address the following comment on pyproject.toml at line 5:
<comment>PyTorch is listed as a build requirement, which will trigger heavyweight installs in the isolated build env; keep build-system requires minimal (build tools only).</comment>
<file context>
@@ -0,0 +1,25 @@
+[build-system]
+requires = [
+ "setuptools>=61",
+ "wheel",
+ "torch==2.1.0",
+ "triton==2.1.0",
+]
</file context>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
|
@cursoragent fix those issues |
|
I refactored dependency management by moving
4 tasks completed
Learn more about Cursor Agents |
Summary
pyproject.tomlwith pinned CUDA and Triton build requirements.env.examplewith GPU arch flags and cache pathsTesting
pytest(fails: TabError, ModuleNotFoundError: yaml)https://chatgpt.com/codex/tasks/task_e_68ab6a20aff08322808d5c4d81ddc7fd
Summary by cubic
Adds pyproject.toml and a GitHub Actions workflow to build CUDA wheels for SM80 and SM90. Updates .env.example with GPU arch and cache settings to standardize local and CI builds.