Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage installation for ST4 users #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FichteFoll
Copy link

@FichteFoll FichteFoll commented Feb 23, 2023

The package is behind the default Python syntax in adopting new syntax features and in adhering to the scoping standards that the community has established for the default packages. It also has access to branching and can thus reliably detect whether a curly brace begins a set or a dict literal over multiple lines.
Besides, the latest update installable via Package Control has been released over 4 years ago because no tag has been pushed to the repo since and that is required for Package Control to pick up new versions.

2023-02-23_20-41-54

Thus, I propose to discourage installation for ST4 users. Users of older versions may still want to install it because their default packages won't receive any updates anymore. You should also push a new tag to the repo to allow installation of the latest changes for ST users of older versions.

@FichteFoll
Copy link
Author

It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether. I can quickly make that change if you agree to it, but I want to confirm this with you first as there may still be some reason that users would want to use MagicPython over the default that I don't know about.

@FichteFoll
Copy link
Author

Bump.

FichteFoll added a commit to wbond/package_control_channel that referenced this pull request Oct 29, 2023
There is very little reason to do this when the default syntax
definition is much better due to using the `sublime-syntax` format,
follows the scope naming standards and is actively maintained, because
this package hasn't had a tag pushed in 4 years despite seeing *some*
changes, albeit the last one over a year ago.

A pull request asking for clarification of the support status for ST4
has not been answered for 8 months.
MagicStack/MagicPython#255
@FichteFoll
Copy link
Author

It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether.

I've gone ahead and did that. We will probably merge it soon, although it can easily be reverted. However, I currently don't see any reason for it.

wbond/package_control_channel#8841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant