Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync SSL shutdown behavior with CPy3.11 asyncio #503

Closed

Conversation

Rongronggg9
Copy link

@Rongronggg9 Rongronggg9 commented Sep 16, 2022

Close #471

For more details refer to #471 (comment) and #471 (comment)

@Rongronggg9 Rongronggg9 marked this pull request as draft September 16, 2022 07:16
@1st1
Copy link
Member

1st1 commented Sep 16, 2022

@Rongronggg9 did you close the PR because it's not needed anymore?

@Rongronggg9
Copy link
Author

Rongronggg9 commented Sep 16, 2022

No, the problem is still unresolved. I closed it because 1) I don't have spare time to dive into the test failures; 2) CPython seemed to adopt the SSL implementation from an earlier version of uvloop so the lack of reading before unwrap is actually an old behavior of uvloop. My opinions have been described in my last reply to #471 (so this PR is an option, as long as someone fixes the test failures).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_SSLProtocolTransport.close() cannot close the connection until timeout or EOF
2 participants