Fixed guest order shipping address overwritten by billing address during order edit #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g order edit When editing a guest order in the admin panel with different billing and shipping addresses, the shipping address was incorrectly overwritten by the billing address during initialization. The `_populateBeforeSaveData()` method unconditionally set `same_as_billing` for new addresses based on guest customer status, overriding explicitly determined address relationships set during order conversion. Added a check for `!$this->hasSameAsBilling()` to preserve explicitly set values while maintaining default behavior for truly new orders. Ported from OpenMage/magento-lts#5213
fballiano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
&& !$this->hasSameAsBilling()check to preserve explicitly setsame_as_billingvalues during order conversionRoot Cause
The
_populateBeforeSaveData()method inMage_Sales_Model_Quote_Addressunconditionally setsame_as_billingfor new addresses based on guest customer status, overriding explicitly determined address relationships set during order conversion.Solution
Modified the condition to check if
same_as_billingwas already explicitly set before overriding it:Credit
Ported from OpenMage: OpenMage/magento-lts#5213