Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SteetMap and TreeMapStreet Layout #3653

Closed
3 tasks done
Richargh opened this issue Jun 24, 2024 · 1 comment · Fixed by #3659
Closed
3 tasks done

Improve SteetMap and TreeMapStreet Layout #3653

Richargh opened this issue Jun 24, 2024 · 1 comment · Fixed by #3659
Assignees
@nxdxnx
Labels
bug Only issues that describe bugs. priority:high Set by PO

Comments

@Richargh
Copy link

Richargh commented Jun 24, 2024 •
edited by nxdxnx
Loading

Feature request

The StreetMap and TreeMapStreet are important layout algorithms because they are refactoring-stable and provide slightly-better view of the logical structure (how the developers grouped code). They haven't received much love so far compared to the Squarified TreeMap and are still more or less experimental. Let's change that.

Description

As a user, I want a clearly arranged CodeMap, so that I can see all the important information and i looks nice.

Acceptance criteria

  • Streets get thicker dynamically by the directory size which it represents
  • Buildings get higher dynamically
  • Files show up first on a street and directories come after that
@nxdxnx
Copy link
Collaborator

nxdxnx commented Jun 26, 2024

For the beginning I just thickened the root/direct child of root street. It depends on whether there is a root file or not.
In addition I changed how the height scale is calculated. Now it´s dynamic and depends on the number of files in the repo, so that you can see the height differences even on very large street maps.
image
image

@ChristianHuehn ChristianHuehn added bug Only issues that describe bugs. priority:high Set by PO labels Jun 26, 2024
@nxdxnx nxdxnx self-assigned this Jun 26, 2024
nxdxnx pushed a commit that referenced this issue Jun 28, 2024
Added that single boxes in a file will show at the front of the stree…
06adc68 
…t and files after that, so that it's organized #3653
@nxdxnx nxdxnx linked a pull request Jun 28, 2024 that will close this issue
Bug/3653/improve steetmap and treemapstreet layout #3657
Closed
6 tasks
@nxdxnx nxdxnx mentioned this issue Jun 28, 2024
Closed
6 tasks
nxdxnx pushed a commit that referenced this issue Jul 8, 2024
directories which contain less then 5 single files are excluded and t…
cc1f55d 
…he layout algorith got a bit revised #3653
nxdxnx pushed a commit that referenced this issue Jul 8, 2024
small adjustments for excluding directories with less than 5 single f…
81ce1b9 
…iles #3653
nxdxnx pushed a commit that referenced this issue Jul 8, 2024
dynamic calculated street thickness #3653
680b6f0
nxdxnx pushed a commit that referenced this issue Jul 8, 2024
small adjustments for excluding directories with fewer than 5 single …
fa69b3c 
…files #3653
@nxdxnx nxdxnx mentioned this issue Jul 12, 2024
Merged
nxdxnx added a commit that referenced this issue Jul 18, 2024
@nxdxnx
fixed test #3653
c50b9f6
nxdxnx added a commit that referenced this issue Jul 18, 2024
@nxdxnx
fixed tests #3653
3bccef0
phanlezz added a commit that referenced this issue Jul 18, 2024
@nxdxnx @phanlezz
Bug/3653/improve steetmap and treemapstreet layout corrected version (#…
9c1acef 
…3659)

* added thicker root street

* modified height scaling

* adapt height scaling

* adapted the height scaling again

* Added that single boxes in a file will show at the front of the street and files after that, so that it's organized #3653

* directories which contain less then 5 single files are excluded and the layout algorith got a bit revised #3653

* small adjustments for excluding directories with less than 5 single files #3653

* dynamic calculated street thickness #3653

* small adjustments for excluding directories with fewer than 5 single files #3653

* fixed test #3653

* fixed tests #3653

---------

Co-authored-by: Nadine Schatz <[email protected]>
Co-authored-by: SebastianW <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nxdxnx nxdxnx

Labels
bug Only issues that describe bugs. priority:high Set by PO
Projects
None yet
Milestone
No milestone
3 participants
@Richargh @nxdxnx @ChristianHuehn