New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/3653/improve steetmap and treemapstreet layout #3657

Open

nxdxnx wants to merge 5 commits into main from bug/3653/improve-steetmap-and-treemapstreet-layout

Collaborator

nxdxnx commented Jun 28, 2024 •

edited

Loading

Small visual adjustments for a better overview

Issue: #3653

Description

Descriptive pull request text

The root street stands out way more then before, because it has it's own thickness
height scaling is dynamic now and is calculated in dependence of directory count
before on a street which contained files and directories there was no specific order, so it looked chaotic
-> now files come first and then directories

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

Changes have been manually tested
All TODOs related to this PR have been closed
There are automated tests for newly written code and bug fixes
All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
CHANGELOG.md has been updated

Screenshots or gifs

Nadine Schatz added 5 commits

June 26, 2024 12:24


          added thicker root street

bdaab16


          modified height scaling

9f1e87d


          adapt height scaling

273f3f9


          adapted the height scaling again

cc55e8c


          Added that single boxes in a file will show at the front of the stree…

06adc68

…t and files after that, so that it's organized #3653

nxdxnx linked an issue

that may be closed by this pull request

Improve SteetMap and TreeMapStreet Layout #3653

Open

sonarcloud bot commented Jun 28, 2024

Quality Gate passed for 'CodeCharta Visualization'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 28, 2024

Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment