Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 3MF export for multi-color 3D printing of maps (supercedes #3616) #3630

Draft
wants to merge 159 commits into
base: main
Choose a base branch
from

Conversation

olexs
Copy link
Collaborator

@olexs olexs commented May 19, 2024

this PR is a copy of #3616 from a local branch instead of fork

Implement 3MF export for multi-color 3D printing of maps

Description

This PR implements a 3MF export in addition to the already existing STL export. This allows to print CodeCharta maps on multi-material printers like the BambuLabs machines or the Prusa XL in multiple colors.

Additionally, the printed map now includes a MW logo, a custom text line, an optional project logo, and a reverse side with a legend of included metrics and their values.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots

Screenshot 2024-05-14 at 17 17 58

IMG_0331
IMG_0325

@BenediktMehl BenediktMehl deleted the feature/3mf_multicolor_export branch May 21, 2024 11:23
@olexs
Copy link
Collaborator Author

olexs commented May 21, 2024

wat? warum closed?

@BridgeAR BridgeAR restored the feature/3mf_multicolor_export branch May 21, 2024 14:59
@BridgeAR BridgeAR reopened this May 21, 2024
@BridgeAR
Copy link
Member

My guess is it was by accident

@BridgeAR
Copy link
Member

BridgeAR commented May 21, 2024

The branch has a couple of conflicts at the moment that would have to be resolved, though.
The overall size is also difficult to review everything.

@phanlezz phanlezz force-pushed the feature/3mf_multicolor_export branch from 13c1763 to ad07dec Compare May 22, 2024 10:38
@phanlezz phanlezz force-pushed the feature/3mf_multicolor_export branch from 8f87305 to 0e25e9b Compare June 10, 2024 07:35
@phanlezz
Copy link
Collaborator

We decided to not fix the issue with the layer height in the folders, because usually the slicer can do it better.

@phanlezz phanlezz force-pushed the feature/3mf_multicolor_export branch 2 times, most recently from dd10e89 to 5eb7c9c Compare June 25, 2024 08:04
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed for 'CodeCharta Visualization'

Failed conditions
33.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jul 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants