📝 Add docstrings to audio/weapondef-soundvariations#2
Open
coderabbitai[bot] wants to merge 5 commits into
Open
📝 Add docstrings to audio/weapondef-soundvariations#2coderabbitai[bot] wants to merge 5 commits into
audio/weapondef-soundvariations#2coderabbitai[bot] wants to merge 5 commits into
Conversation
Fixed broken cherry-pick
The fallback should only apply to sounds defs for hitting dry land or wet water, where they should instead use the generic soundHit. Also fixed the table case not having a fallback
Docstrings generation was requested by @Majavaa. * #1 (comment) The following files were modified: * `rts/Sim/Weapons/WeaponDef.cpp`
Author
|
Important Review skippedCodeRabbit bot authored PR detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
lhog
force-pushed
the
audio/weapondef-soundvariations
branch
2 times, most recently
from
6896505 to
7d39901
Compare
lhog
force-pushed
the
audio/weapondef-soundvariations
branch
from
7d39901 to
0bf65d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @Majavaa.
The following files were modified:
rts/Sim/Weapons/WeaponDef.cppℹ️ Note