Verify records Swift Testing issue with source location. #369
+758
−710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stannieman
force-pushed
the
Swift_Testing_support
branch
2 times, most recently
from
7424de3 to
4245adf
Compare
Stannieman
commented
Feb 14, 2025
| } | ||
| return | ||
| } | ||
| #endif |
There was a problem hiding this comment.
The part above is the only thing that's needed to make the test correctly fail in Swift Testing. All the rest is just to make it show in the editor.
| #endif | ||
|
|
||
| #if canImport(XCTest) | ||
| XCTAssert(expression(), message(), file: filePath, line: line) |
There was a problem hiding this comment.
I changed file to filePath here because XCTAssert's default parameter is #filePath as well. Is this a correct thing to do? It still shows up at the correct place in source in the editor.
Stannieman
force-pushed
the
Swift_Testing_support
branch
from
4245adf to
5b23428
Compare
|
Great to see this, thanks @Stannieman! @spaluchiewicz any help on getting this in is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify failed silently in Swift Testing because it does not pick up
XCTAssertfailure used inMockyAssert.This PR uses Swift Testing's Issue.record IF running inside a Swift Testing test. Additionally there is a bunch of changes to make the error show at the correct place in source in the editor.